Fix openscad parser indescriminately replacing all collision meshes #175
Open
marcin-nrobotics wants to merge 1 commit intoRhoban:masterfrom
Open
Fix openscad parser indescriminately replacing all collision meshes #175marcin-nrobotics wants to merge 1 commit intoRhoban:masterfrom
marcin-nrobotics wants to merge 1 commit intoRhoban:masterfrom
Conversation
|
I ran into the same issue. It would be nice if this fix can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Current behaviour of the code for replacing meshes with pure shapes is not in line with the documentation as presented in the documentation video.
Current behaviour
If
ProcessorScadis used, it goes through all collision meshes. If there is no*.scadfile for a given mesh, it still gets replaced with nothing (mesh.collision = False)New behaviour
If
ProcessorScadis used, it only uses pure shapes to replace meshes for which*.scadfiles exist, leaving all other meshes intact.