Skip to content

Use buffer writer api with json reader #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afprtclr merged 21 commits into from
Jan 23, 2026
Merged

Use buffer writer api with json reader #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
05a1afc
Update to Core version with the buffer writer API
mauroservienti Jan 13, 2026
289cb15
Remove the unwrappers not needed for the perf tests
mauroservienti Jan 13, 2026
6032bb0
Update to use the new API based on the buffer writer
mauroservienti Jan 13, 2026
65d67f3
benchmarks
mauroservienti Jan 13, 2026
3c9b160
Use Core compiled in Release mode
mauroservienti Jan 13, 2026
dd71a2d
Benchmark results
mauroservienti Jan 13, 2026
d72baf9
Remove not needed tests
mauroservienti Jan 13, 2026
48e24e7
Approved API
mauroservienti Jan 13, 2026
06162b8
Use SAX parser Utf8JsonReader
mauroservienti Jan 13, 2026
13b31b7
Benchmarks results
mauroservienti Jan 13, 2026
eba755d
Update to latest Core with the new buffer writer API
mauroservienti Jan 15, 2026
4fde24d
Remove benchmarks from this branch
mauroservienti Jan 15, 2026
76d46d3
Bringing back other implementations
afprtclr Jan 19, 2026
d525d1c
Bringing back acceptance tests
afprtclr Jan 20, 2026
69e762c
Update src/NServiceBus.Envelope.CloudEvents/NServiceBus.Envelope.Clou…
mauroservienti Jan 21, 2026
95fa565
Cleanup using directives
mauroservienti Jan 21, 2026
bf3e42c
Remove redundant elements
mauroservienti Jan 21, 2026
cdec9f3
Ensure namespace consistency across acceptance tests
mauroservienti Jan 21, 2026
1f691ea
Include cloud events specific ATTs into transports specific ATT projects
mauroservienti Jan 21, 2026
812ce68
Fix partial comment
mauroservienti Jan 21, 2026
01add33
Updating packages and making type mapping case insensitive
afprtclr Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...Bus.Envelope.CloudEvents.ASB.AcceptanceTests/ConfigureEndpointAzureServiceBusTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
using System;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.Extensions.DependencyInjection;
using NServiceBus;
using Microsoft.Extensions.DependencyInjection;
using NServiceBus.AcceptanceTesting.Customization;
using NServiceBus.AcceptanceTesting.Support;
using NServiceBus.Envelope.CloudEvents.ASB.AcceptanceTests;
Expand Down
17 changes: 15 additions & 2 deletions ...oudEvents.ASB.AcceptanceTests/NServiceBus.Envelope.CloudEvents.ASB.AcceptanceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RootNamespace>NServiceBus.AcceptanceTests</RootNamespace>
</PropertyGroup>

<ItemGroup>
Expand All @@ -14,15 +15,27 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.Transport.AzureServiceBus" Version="6.0.0-alpha.4" />
<PackageReference Include="NServiceBus.Transport.AzureServiceBus" Version="6.0.0" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.0.0-cloudevents.1" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.1.0-alpha.1" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\NServiceBus.Envelope.CloudEvents\NServiceBus.Envelope.CloudEvents.csproj" />
</ItemGroup>

<ItemGroup>
<Compile Include="..\NServiceBus.Envelope.CloudEvents.AcceptanceTests\CloudEvents\When_amqp_binary_message_received.cs">
<Link>CloudEvents\When_amqp_binary_message_received.cs</Link>
</Compile>
<Compile Include="..\NServiceBus.Envelope.CloudEvents.AcceptanceTests\CloudEvents\When_http_binary_message_received.cs">
<Link>CloudEvents\When_http_binary_message_received.cs</Link>
</Compile>
<Compile Include="..\NServiceBus.Envelope.CloudEvents.AcceptanceTests\CloudEvents\When_json_structured_message_received.cs">
<Link>CloudEvents\When_json_structured_message_received.cs</Link>
</Compile>
</ItemGroup>

</Project>
4 changes: 2 additions & 2 deletions src/NServiceBus.Envelope.CloudEvents.ASB.AcceptanceTests/TestIndependenceSkipBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
namespace NServiceBus.Envelope.CloudEvents.ASB.AcceptanceTests;

using NServiceBus.AcceptanceTesting;
using NServiceBus.Pipeline;
using AcceptanceTesting;
using NUnit.Framework;
using Pipeline;

class TestIndependenceSkipBehavior : IBehavior<ITransportReceiveContext, ITransportReceiveContext>
{
Expand Down
16 changes: 6 additions & 10 deletions ...Bus.Envelope.CloudEvents.AcceptanceTests/CloudEvents/When_amqp_binary_message_received.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
namespace NServiceBus.Envelope.CloudEvents.AcceptanceTests.CloudEvents;
namespace NServiceBus.AcceptanceTests.CloudEvents;

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using AcceptanceTesting;
using Configuration.AdvancedExtensibility;
using NServiceBus.AcceptanceTests;
using NServiceBus.AcceptanceTests.EndpointTemplates;
using Pipeline;
using Transport;
using EndpointTemplates;
using Envelope.CloudEvents;
using NServiceBus.Pipeline;
using NUnit.Framework;
using Transport;

public class When_amqp_binary_message_received : NServiceBusAcceptanceTest
{
Expand All @@ -25,7 +21,7 @@ public async Task An_amqp_binary_cloud_event_is_received()
// Azure sends CloudEvents as JSON Structured. Below is the equivalent
// in the AMQP Binary format.
// The headers are set in the CustomSerializationBehavior.
return b.SendLocal(new Message()
return b.SendLocal(new Message
{
Api = "PutBlockList",
ClientRequestId = "4c5dd7fb-2c48-4a27-bb30-5361b5de920a",
Expand Down
16 changes: 6 additions & 10 deletions ...Bus.Envelope.CloudEvents.AcceptanceTests/CloudEvents/When_http_binary_message_received.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
namespace NServiceBus.Envelope.CloudEvents.AcceptanceTests.CloudEvents;
namespace NServiceBus.AcceptanceTests.CloudEvents;

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using AcceptanceTesting;
using Configuration.AdvancedExtensibility;
using NServiceBus.AcceptanceTests;
using NServiceBus.AcceptanceTests.EndpointTemplates;
using Pipeline;
using Transport;
using EndpointTemplates;
using Envelope.CloudEvents;
using NServiceBus.Pipeline;
using NUnit.Framework;
using Transport;

public class When_http_binary_message_received : NServiceBusAcceptanceTest
{
Expand All @@ -25,7 +21,7 @@ public async Task An_http_binary_cloud_event_is_received()
// Azure sends CloudEvents as JSON Structured. Below is the equivalent
// in the HTTP Binary format.
// The headers are set in the CustomSerializationBehavior.
return b.SendLocal(new Message()
return b.SendLocal(new Message
{
Api = "PutBlockList",
ClientRequestId = "4c5dd7fb-2c48-4a27-bb30-5361b5de920a",
Expand Down
18 changes: 7 additions & 11 deletions ...Envelope.CloudEvents.AcceptanceTests/CloudEvents/When_json_structured_message_received.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
namespace NServiceBus.Envelope.CloudEvents.AcceptanceTests.CloudEvents;
namespace NServiceBus.AcceptanceTests.CloudEvents;

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using AcceptanceTesting;
using Configuration.AdvancedExtensibility;
using NServiceBus.AcceptanceTests;
using NServiceBus.AcceptanceTests.EndpointTemplates;
using Pipeline;
using Transport;
using EndpointTemplates;
using Envelope.CloudEvents;
using NServiceBus.Pipeline;
using NUnit.Framework;
using Transport;

public class When_json_structured_message_received : NServiceBusAcceptanceTest
{
Expand All @@ -23,7 +19,7 @@ public async Task A_json_structured_cloud_event_is_received()
// The following represents a CloudEvent that Azure Blob Storage generates
// to notify that a new blob item has been created.
// The headers are set in the CustomSerializationBehavior.
return b.SendLocal(new Message()
return b.SendLocal(new Message
{
SpecVersion = "1.0",
Type = "Microsoft.Storage.BlobCreated",
Expand All @@ -32,7 +28,7 @@ public async Task A_json_structured_cloud_event_is_received()
Id = "9aeb0fdf-c01e-0131-0922-9eb54906e209",
Time = "2019-11-18T15:13:39.4589254Z",
Subject = "blobServices/default/containers/{storage-container}/blobs/{new-file}",
Data = new NestedData()
Data = new NestedData
{
Api = "PutBlockList",
ClientRequestId = "4c5dd7fb-2c48-4a27-bb30-5361b5de920a",
Expand Down
6 changes: 1 addition & 5 deletions ...CloudEvents.AcceptanceTests/ConfigureEndpointAcceptanceTestingTransportWithCloudEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
namespace NServiceBus.AcceptanceTests;

using System;
using System.IO;
using System.Threading.Tasks;
using AcceptanceTesting.Customization;
using NServiceBus;
using NServiceBus.AcceptanceTesting.Support;
using AcceptanceTesting.Support;
using NUnit.Framework;

public class ConfigureEndpointAcceptanceTestingTransportWithCloudEvents(
Expand Down
3 changes: 2 additions & 1 deletion ...elope.CloudEvents.AcceptanceTests/NServiceBus.Envelope.CloudEvents.AcceptanceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RootNamespace>NServiceBus.AcceptanceTests</RootNamespace>
</PropertyGroup>

<ItemGroup>
Expand All @@ -13,7 +14,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.0.0-cloudevents.1" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.1.0-alpha.1" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 0 additions & 4 deletions src/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests/Cleanup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
namespace NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests;

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Amazon.S3;
using Amazon.S3.Model;
using Amazon.S3.Util;
Expand Down
1 change: 0 additions & 1 deletion src/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests/ClientFactories.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests;

using System;
using Amazon.Runtime;
using Amazon.S3;
using Amazon.SimpleNotificationService;
Expand Down
1 change: 0 additions & 1 deletion src/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests/ConfigureEndpointSqsTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
namespace NServiceBus.AcceptanceTests;

using System.Threading.Tasks;
using AcceptanceTesting.Customization;
using AcceptanceTesting.Support;
using Envelope.CloudEvents.SQS.AcceptanceTests;
Expand Down
16 changes: 14 additions & 2 deletions ...oudEvents.SQS.AcceptanceTests/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,29 @@
<ItemGroup>
<PackageReference Include="GitHubActionsTestLogger" Version="3.0.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="NServiceBus.AmazonSQS" Version="9.0.0-alpha.5" />
<PackageReference Include="NServiceBus.AmazonSQS" Version="9.0.0" />
<PackageReference Include="NUnit" Version="4.4.0" />
<PackageReference Include="NUnit3TestAdapter" Version="5.2.0" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.0.0-cloudevents.1" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.1.0-alpha.1" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\NServiceBus.Envelope.CloudEvents\NServiceBus.Envelope.CloudEvents.csproj" />
</ItemGroup>

<ItemGroup>
<Compile Include="..\NServiceBus.Envelope.CloudEvents.AcceptanceTests\CloudEvents\When_amqp_binary_message_received.cs">
<Link>CloudEvents\When_amqp_binary_message_received.cs</Link>
</Compile>
<Compile Include="..\NServiceBus.Envelope.CloudEvents.AcceptanceTests\CloudEvents\When_http_binary_message_received.cs">
<Link>CloudEvents\When_http_binary_message_received.cs</Link>
</Compile>
<Compile Include="..\NServiceBus.Envelope.CloudEvents.AcceptanceTests\CloudEvents\When_json_structured_message_received.cs">
<Link>CloudEvents\When_json_structured_message_received.cs</Link>
</Compile>
</ItemGroup>

</Project>
2 changes: 0 additions & 2 deletions src/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests/SetupFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
namespace NServiceBus.AcceptanceTests;

using System;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
using Envelope.CloudEvents.SQS.AcceptanceTests;
using NUnit.Framework;

Expand Down
2 changes: 0 additions & 2 deletions src/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests/TestNameHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
namespace NServiceBus.AcceptanceTests;

using System;
using System.Linq;
using System.Text;

static class TestNameHelper
Expand Down
3 changes: 1 addition & 2 deletions src/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests/When_receiving_http_binary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
namespace NServiceBus.AcceptanceTests;

using System.Text.Json;
using System.Threading.Tasks;
using Amazon.SQS.Model;
using AcceptanceTesting;
using AcceptanceTesting.Customization;
using Amazon.SQS.Model;
using Configuration.AdvancedExtensibility;
using EndpointTemplates;
using Envelope.CloudEvents;
Expand Down
Loading