Use buffer writer api with json reader#37
Merged
afprtclr merged 21 commits intomove-envelope-handlerfrom Jan 23, 2026
Merged
Conversation
We still have them on the `-with-benchmarks` branch
afprtclr
approved these changes
Jan 20, 2026
mauroservienti
commented
Jan 21, 2026
src/NServiceBus.Envelope.CloudEvents/NServiceBus.Envelope.CloudEvents.csproj
Outdated
Show resolved
Hide resolved
mauroservienti
commented
Jan 21, 2026
src/NServiceBus.Envelope.CloudEvents.SQS.AcceptanceTests/When_receiving_http_binary.cs
Show resolved
Hide resolved
mauroservienti
commented
Jan 21, 2026
| { | ||
| var cloudEventType = receivedCloudEvent[CloudEventJsonStructuredConstants.TypeProperty].Value.GetString()!; | ||
| var cloudEventType = receivedCloudEvent[CloudEventJsonStructuredConstants.TypeProperty].GetString(); | ||
| return config.TypeMappings.TryGetValue(cloudEventType, out var typeMapping) |
Member
Author
There was a problem hiding this comment.
Is the TryGetValue case sensitive? If yes, should we try to make this extraction more permissive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.