Skip to content

fix: Toggle-button instead of checkbox for filter/display #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aiAdrian wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Toggle-button instead of checkbox for filter/display #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b81890
fix: Toggle-button instead of checkbox for filter/display
aiAdrian Feb 23, 2026
c105828
refactor: removed unused html tag
aiAdrian Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 51 additions & 41 deletions src/app/view/editor-filter-view/editor-filter-view.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,59 +154,69 @@ <h2 class="SummaryTitle">{{ "app.view.editor-filter-view.filter" | translate }}<
</sbb-form-field>

<sbb-label>{{ "app.view.editor-filter-view.Round-trips" | translate }}</sbb-label>
<div class="sbb-checkbox-group-vertical">
<sbb-checkbox [(ngModel)]="filterDirectionArrows" (change)="filterDirectionArrowsChanged()"
>{{ "app.view.editor-filter-view.display-direction-arrows" | translate }}
</sbb-checkbox>
</div>
<sbb-toggle-switch-button
[labelTrue]="'app.view.editor-filter-view.display-direction-arrows' | translate"
[checked]="filterDirectionArrows"
(checkedChanged)="filterDirectionArrowsChanged()"
/>

<br />
<sbb-label>{{ "app.view.editor-filter-view.times" | translate }}</sbb-label>
<div class="sbb-checkbox-group-vertical">
<sbb-checkbox
[(ngModel)]="filterArrivalDepartureTime"
(change)="filterArrivalDepartureTimeChanged()"
>{{ "app.view.editor-filter-view.display-arrival-departure-times" | translate }}
</sbb-checkbox>
<sbb-checkbox [(ngModel)]="filterShowNonStopTime" (change)="filterShowNonStopTimeChanged()">
{{
"app.view.editor-filter-view.display-arrival-departure-times-for-connections" | translate
}}
</sbb-checkbox>
<sbb-checkbox [(ngModel)]="filterTravelTime" (change)="filterTravelTimeChanged()"
>{{ "app.view.editor-filter-view.display-travel-times" | translate }}
</sbb-checkbox>
<sbb-checkbox [(ngModel)]="filterTrainrunName" (change)="filterTrainrunNameChanged()"
>{{ "app.view.editor-filter-view.display-trainrun-name" | translate }}
</sbb-checkbox>
</div>
<sbb-toggle-switch-button
[labelTrue]="'app.view.editor-filter-view.display-arrival-departure-times' | translate"
[checked]="filterArrivalDepartureTime"
(checkedChanged)="filterArrivalDepartureTimeChanged()"
/>
<sbb-toggle-switch-button
[labelTrue]="
'app.view.editor-filter-view.display-arrival-departure-times-for-connections' | translate
"
[checked]="filterShowNonStopTime"
(checkedChanged)="filterShowNonStopTimeChanged()"
/>
<sbb-toggle-switch-button
[labelTrue]="'app.view.editor-filter-view.display-travel-times' | translate"
[checked]="filterTravelTime"
(checkedChanged)="filterTravelTimeChanged()"
/>
<sbb-toggle-switch-button
[labelTrue]="'app.view.editor-filter-view.display-trainrun-name' | translate"
[checked]="filterTrainrunName"
(checkedChanged)="filterTrainrunNameChanged()"
/>

<br />
<sbb-label>{{ "app.view.editor-filter-view.connections" | translate }}</sbb-label>
<div class="sbb-checkbox-group-vertical">
<sbb-checkbox [(ngModel)]="filterConnections" (change)="filterConnectionsChanged()"
>{{ "app.view.editor-filter-view.display-connections" | translate }}
</sbb-checkbox>
</div>
<sbb-toggle-switch-button
[labelTrue]="'app.view.editor-filter-view.display-connections' | translate"
[checked]="filterConnections"
(checkedChanged)="filterConnectionsChanged()"
/>

<br />
<sbb-label>{{ "app.view.editor-filter-view.nodes" | translate }}</sbb-label>
<div class="sbb-checkbox-group-vertical">
<sbb-checkbox [(ngModel)]="filterAllEmptyNodes" (change)="filterAllEmptyNodesChanged()"
>{{ "app.view.editor-filter-view.display-nodes-without-visible-trainruns" | translate }}
</sbb-checkbox>
<sbb-checkbox [(ngModel)]="filterAllNonStopNodes" (change)="filterAllNonStopNodesChanged()"
>{{ "app.view.editor-filter-view.display-nodes-with-only-stopping-trainruns" | translate }}
</sbb-checkbox>
</div>
<sbb-toggle-switch-button
[labelTrue]="
'app.view.editor-filter-view.display-nodes-without-visible-trainruns' | translate
"
[checked]="filterAllEmptyNodes"
(checkedChanged)="filterAllEmptyNodesChanged()"
/>
<sbb-toggle-switch-button
[labelTrue]="
'app.view.editor-filter-view.display-nodes-with-only-stopping-trainruns' | translate
"
[checked]="filterAllNonStopNodes"
(checkedChanged)="filterAllNonStopNodesChanged()"
/>

<br />
<sbb-label>{{ "app.view.editor-filter-view.notes" | translate }}</sbb-label>
<div class="sbb-checkbox-group-vertical">
<sbb-checkbox [(ngModel)]="filterNotes" (change)="filterNotesChanged()"
>{{ "app.view.editor-filter-view.display-notes" | translate }}
</sbb-checkbox>
</div>
<sbb-toggle-switch-button
[labelTrue]="'app.view.editor-filter-view.display-notes' | translate"
[checked]="filterNotes"
(checkedChanged)="filterNotesChanged()"
/>

<button
sbb-secondary-button
Expand Down
18 changes: 9 additions & 9 deletions src/app/view/editor-filter-view/editor-filter-view.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,71 +178,71 @@ export class EditorFilterViewComponent implements OnInit, OnDestroy {
}

filterAllEmptyNodesChanged() {
if (!this.filterAllEmptyNodes) {
if (this.filterAllEmptyNodes) {
this.filterService.enableFilterAllEmptyNodes();
} else {
this.filterService.disableFilterAllEmptyNodes();
}
}

filterNotesChanged() {
if (!this.filterNotes) {
if (this.filterNotes) {
this.filterService.enableFilterNotes();
} else {
this.filterService.disableFilterNotes();
}
}

filterAllNonStopNodesChanged() {
if (!this.filterAllNonStopNodes) {
if (this.filterAllNonStopNodes) {
this.filterService.enableFilterAllNonStopNodes();
} else {
this.filterService.disableFilterAllNonStopNodes();
}
}

filterDirectionArrowsChanged() {
if (this.filterDirectionArrows) {
if (!this.filterDirectionArrows) {
this.filterService.enableFilterDirectionArrows();
} else {
this.filterService.disableFilterDirectionArrows();
}
}

filterArrivalDepartureTimeChanged() {
if (this.filterArrivalDepartureTime) {
if (!this.filterArrivalDepartureTime) {
this.filterService.enableFilterArrivalDepartureTime();
} else {
this.filterService.disableFilterArrivalDepartureTime();
}
}

filterShowNonStopTimeChanged() {
if (this.filterShowNonStopTime) {
if (!this.filterShowNonStopTime) {
this.filterService.enableFilterShowNonStopTime();
} else {
this.filterService.disableFilterShowNonStopTime();
}
}

filterTravelTimeChanged() {
if (this.filterTravelTime) {
if (!this.filterTravelTime) {
this.filterService.enableFilterTravelTime();
} else {
this.filterService.disableFilterTravelTime();
}
}

filterTrainrunNameChanged() {
if (this.filterTrainrunName) {
if (!this.filterTrainrunName) {
this.filterService.enableFilterTrainrunName();
} else {
this.filterService.disableFilterTrainrunName();
}
}

filterConnectionsChanged() {
if (this.filterConnections) {
if (!this.filterConnections) {
this.filterService.enableFilterConnections();
} else {
this.filterService.disableFilterConnections();
Expand Down