Skip to content

fix: Toggle-button instead of checkbox for filter/display#855

Open
aiAdrian wants to merge 2 commits intomainfrom
854-filter---display---replace-checkbox-with-toggle-button
Open

fix: Toggle-button instead of checkbox for filter/display#855
aiAdrian wants to merge 2 commits intomainfrom
854-filter---display---replace-checkbox-with-toggle-button

Conversation

@aiAdrian
Copy link
Contributor

@aiAdrian aiAdrian commented Feb 23, 2026

chrome-capture-2026-02-23.2.webm
chrome-capture-2026-02-24.webm

@aiAdrian aiAdrian linked an issue Feb 23, 2026 that may be closed by this pull request
@aiAdrian aiAdrian self-assigned this Feb 23, 2026
@aiAdrian aiAdrian force-pushed the 854-filter---display---replace-checkbox-with-toggle-button branch from f03b03b to 2b81890 Compare February 24, 2026 07:51
@aiAdrian aiAdrian changed the title fit: Toggle-button instead of checkbox for filter/display fix: Toggle-button instead of checkbox for filter/display Feb 24, 2026
@emersion
Copy link
Member

emersion commented Feb 24, 2026

This doesn't seem to be a fix. I don't think the PR should have the "fix" prefix.

What is the motivation for converting everything to checkboxes? Checkboxes have a different semantic than switch buttons. I don't think all checkboxes should be blindly converted to swicth buttons.

(To be clear, I'm not necessarily saying it doesn't make sense to use switch buttons in this PR's particular instances. I'm asking whether there is a meaning behind the change, other than "switch buttons always look better in all situations", which I disagree with.)

@louisgreiner
Copy link
Contributor

I don't think to be relevant on this UI/UX topic, we should probably ask our designer.

As a personnal point of view, toggles "overload" the view here, like in an aircraft dashboard or something similar

@aiAdrian
Copy link
Contributor Author

aiAdrian commented Feb 24, 2026

@louisgreiner Please ask your UX/UI experts. This was a feature / fix request from our users. The like to have the switch button for all checkbox -> to have same look-and-feel - e.g. enable / disable one-way .... or as well for future asym. times.

@thibautsailly
Copy link

Hello Adrian, could you explain in more detail what was the problem users wanted to fix? This will help me provide a more informed and accurate answer. Thank you!

@aiAdrian
Copy link
Contributor Author

aiAdrian commented Feb 24, 2026

@thibautsailly

The current version has two different UI elements for switching on/off or toggling:

  • Checkbox
  • Toggle switch button

Our users prefer the buttons : toggle-switch button

e.g. the toggle-switch button is used in the node, which is very well received by the users. And now they also want to have the toggle switch button in the filter -> display. This is what triggered this change.

But I’m very happy if you check this UI technically and provide feedback from UX point of view

chrome-capture-2026-02-24.1.webm

@thibautsailly
Copy link

Thank you @aiAdrian for the precisions, but we are going to need some more I'm afraid 🙂.
Product design is really effective when choices can be explained with arguments more precise than "I prefer this to that". I'm not saying user preference isn't real and should be discarded, but that it has to be explained more objectively than a feeling of appreciation. This extra exploration will help us fully understand their preference and make an informed UI decision.

Reliable sources (IBM and macOS design system documentations) indicate that in this particular case, checkboxes should be used over toggle switches. But I have a strong guess about why they said to prefer toggles over checkboxes. I would like to check this guess: do you think you we could ask them a more detailed feedback? If yes, could you send them this question?

Please select the reasons why you prefer toggle switches over checkboxes:

  • the shape of the element is more appealing
  • the screen looks more organised with toggle switches
  • the animation is pleasing
  • it's easier to spot which line is on or off at a glance
  • checkboxes look like the 1990s, toggles are more 2020s

If not, we'll go with my informed and later explained guess.

@aiAdrian
Copy link
Contributor Author

@martin will answer open the questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter - Display - Replace checkbox with toggle-button

4 participants