Skip to content

fix: correct SNR_threshold type annotation and xarray scalar extraction #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beatfactor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct SNR_threshold type annotation and xarray scalar extraction #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion echopype/calibrate/cal_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ def _get_fs():
# loop through channel since transceiver can vary
fs = []
for ch in vend["channel"]:
tcvr_type = vend["transceiver_type"].sel(channel=ch).data.tolist().upper()
tcvr_type = vend["transceiver_type"].sel(channel=ch).values.item().upper()
fs.append(default_params["receiver_sampling_frequency"][tcvr_type])
return xr.DataArray(fs, dims=["channel"], coords={"channel": vend["channel"]})

Expand Down
2 changes: 1 addition & 1 deletion echopype/clean/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def remove_background_noise(
ping_num: int,
range_sample_num: int,
background_noise_max: str = None,
SNR_threshold: float = "3.0dB",
SNR_threshold: str = "3.0dB",
) -> xr.Dataset:
"""
Remove noise by using estimates of background noise
Expand Down
Loading