fix: correct SNR_threshold type annotation and xarray scalar extraction#1622
Open
beatfactor wants to merge 1 commit intoOSOceanAcoustics:mainfrom
Open
Conversation
Contributor
beatfactor
commented
Mar 12, 2026
- clean/api.py: Change SNR_threshold parameter type hint from float to str to match its default value '3.0dB'
- calibrate/cal_params.py: Use .values.item() instead of .data.tolist() for xarray scalar extraction (forward-compatible API)
- clean/api.py: Change SNR_threshold parameter type hint from float to str to match its default value '3.0dB' - calibrate/cal_params.py: Use .values.item() instead of .data.tolist() for xarray scalar extraction (forward-compatible API)
e315041 to
88c6c53
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
+ Coverage 84.90% 85.56% +0.65%
==========================================
Files 79 79
Lines 6998 6998
==========================================
+ Hits 5942 5988 +46
+ Misses 1056 1010 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.