Add conformance tests for is_unit & is_nilpotent#1947
Add conformance tests for is_unit & is_nilpotent#1947
is_unit & is_nilpotent#1947Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1947 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 126 126
Lines 32073 32098 +25
=======================================
+ Hits 28279 28302 +23
- Misses 3794 3796 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test fails: Perhaps someone (@JohnAAbbott ?) can look into adding that method next year. In the meantime we could make the test conditional here and skip it if a not-implemented-exception is thrown... |
|
@fieker @thofma @lgoettgens just talking to @JohnAAbbott whether we can implement So we probably should not insist on this being available. But what would be a good strategy to have such tests (they are useful, I found several bugs in our current code with them!) but allow some rings to opt-out of them because they don't implement a certain feature? |
bc85fed to
ae49289
Compare
Also improve is_nilpotent for matrices / matrix ring elements to work if the base ring is trivial.
ae49289 to
8d86cbd
Compare
is_unit & is_nilpotent
Also improve is_nilpotent for matrices / matrix ring elements to work if the base ring is trivial.
Resolves #1941