Drop is_unit tests from test_NCRing_interface to comply with interface definitions#2362
Merged
fingolfin merged 1 commit intoNemocas:masterfrom Feb 27, 2026
Merged
Conversation
SoongNoonien
added
the
release notes: not needed
SoongNoonien
approved these changes
Feb 27, 2026
Collaborator
SoongNoonien
left a comment
SoongNoonien
left a comment
There was a problem hiding this comment.
This seems reasonable. The tests weren't that useful before anyway.
Collaborator
|
By the way the SingularCI test failure is of course not related to your changes. It should be fixed soon: oscar-system/Singular.jl#928 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2362 +/- ##
==========================================
- Coverage 88.19% 88.18% -0.01%
==========================================
Files 127 127
Lines 32851 32849 -2
==========================================
- Hits 28973 28968 -5
- Misses 3878 3881 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Should be a try catch like the other optional things imho. |
Member
fingolfin
approved these changes
Feb 27, 2026
lgoettgens
changed the title
NCRing interfaceis_unit tests from test_NCRing_interface to comply with interface definitions
lgoettgens
added
test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all calls to
is_unitfromtest_NCRing_interface.The documentation says that implementation of
is_unitis optional, but at the moment it is not. For our new cohomology rings in Oscar it is in fact not trivial to implement this function (I think), so we would like to be able to not write a mathematically incorrect stub in order to make the tests pass.