Support stdlib-style logger arguments#66
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%arguments andexc_info=while preservingrank0_only=behavior_worker_exceptionis recorded when the background export failsWhy
HFExportCallback._save_and_upload()logs worker failures with stdlib-style logger arguments. The project logger wrappers only accepted(message, rank0_only=True), so that error path could raiseTypeErrorbefore_worker_exceptionwas assigned.I chose to fix the shared wrapper instead of only rewriting the callback call site because the repo already has other callers using the same
%-style logging pattern. This keeps the callback guarantee intact and removes the same footgun for those existing call sites too.Validation
uvx ruff check /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/utils/log.py /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/utils/log_test.py /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/callbacks/hf_export_test.pyuvx ruff format --check /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/utils/log.py /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/utils/log_test.py /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/callbacks/hf_export_test.pyPYTHONPATH=/Users/hoangvu/Code/OSS/cosmos-framework uvx pytest --noconftest /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/utils/log_test.py /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/callbacks/hf_export_test.py -o addopts=