refactor: migrate account-exist and account-not-found to design-system-react (onboarding)#40735
Open
refactor: migrate account-exist and account-not-found to design-system-react (onboarding)#40735
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (8 files, +214 -201)
|
Contributor
Builds ready [9732ae9]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
ui/pages/onboarding-flow/account-status-layout/account-status-layout.tsx
Outdated
Show resolved
Hide resolved
Contributor
Builds ready [fb68e91]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Contributor
Builds ready [c1d838c]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The onboarding flow pages "Account exist" and "Account not found" (seedless onboarding) currently use the legacy component library and design-system constants (
Display,AlignItems,JustifyContent,BlockSize, etc.). The codebase is moving to@metamask/design-system-reactfor consistency and maintainability.Changelog
CHANGELOG entry: migrate account-exist and account-not-found to design-system-react
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Primarily a UI refactor to a shared layout component with minimal logic changes; risk is limited to potential styling/regression in onboarding page rendering and click wiring.
Overview
Refactors the seedless onboarding
AccountExistandAccountNotFoundpages to use a new sharedAccountStatusLayoutbuilt on@metamask/design-system-react, removing the legacy component-library/design-system constants and duplicative markup.Adds
AccountStatusLayout(with types + tests) to standardize title/description rendering via i18n keys and provide consistent primary/secondary CTA buttons, while keeping existing navigation and metrics behavior intact. Updates Jest console baselines and adjusts tests to stop asserting DOM node type for the CTAs.Written by Cursor Bugbot for commit c1d838c. This will update automatically on new commits. Configure here.