Conversation
Implements an amplitude that is a control relative to an existing reference.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
========================================
+ Coverage 90.5% 90.8% +0.4%
========================================
Files 37 37
Lines 2661 2762 +101
========================================
+ Hits 2407 2507 +100
- Misses 254 255 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new GuidedAmplitude type to express an amplitude as a shaped control offset by a reference/guide, fitting into the existing Amplitudes module alongside LockedAmplitude and ShapedAmplitude.
Changes:
- Export and implement
GuidedAmplitudewith constructors,show,evaluate,Array, andsubstitutesupport. - Add extensive tests covering callable/vector combinations, number guides, invalid constructions, and substitution behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/amplitudes.jl |
Implements and exports GuidedAmplitude and its evaluation/substitution behavior. |
test/test_amplitudes.jl |
Adds coverage for GuidedAmplitude construction and evaluation modes, plus error cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements an amplitude that is a control relative to an existing reference.