Skip to content

Implement GuidedAmplitude#111

Merged
goerz merged 1 commit intomasterfrom
guided-amplitude
May 3, 2026
Merged

Implement GuidedAmplitude#111
goerz merged 1 commit intomasterfrom
guided-amplitude

Conversation

@goerz
Copy link
Copy Markdown
Member

@goerz goerz commented May 3, 2026

Implements an amplitude that is a control relative to an existing reference.

Implements an amplitude that is a control relative to an existing
reference.
@goerz goerz added the enhancement New feature or request label May 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 99.00990% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.8%. Comparing base (45a992f) to head (270fbff).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/amplitudes.jl 99.1% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #111     +/-   ##
========================================
+ Coverage    90.5%   90.8%   +0.4%     
========================================
  Files          37      37             
  Lines        2661    2762    +101     
========================================
+ Hits         2407    2507    +100     
- Misses        254     255      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GuidedAmplitude type to express an amplitude as a shaped control offset by a reference/guide, fitting into the existing Amplitudes module alongside LockedAmplitude and ShapedAmplitude.

Changes:

  • Export and implement GuidedAmplitude with constructors, show, evaluate, Array, and substitute support.
  • Add extensive tests covering callable/vector combinations, number guides, invalid constructions, and substitution behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/amplitudes.jl Implements and exports GuidedAmplitude and its evaluation/substitution behavior.
test/test_amplitudes.jl Adds coverage for GuidedAmplitude construction and evaluation modes, plus error cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/amplitudes.jl
@goerz goerz merged commit 9f67764 into master May 3, 2026
11 checks passed
@goerz goerz deleted the guided-amplitude branch May 3, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants