Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
========================================
+ Coverage 87.7% 87.7% +0.1%
========================================
Files 20 20
Lines 1123 1124 +1
========================================
+ Hits 984 985 +1
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds get_control_deriv support for QuantumPropagators.Amplitudes.GuidedAmplitude so gradient/derivative extraction works consistently across amplitude types, following the upstream QuantumPropagators.jl changes.
Changes:
- Add
get_control_deriv(::GuidedAmplitude, control)returningLockedAmplitude(shape)for the matching control. - Extend derivative tests to cover
GuidedAmplitude, including the discretized-on-tlistconstructor case. - Tighten/import adjustments in the derivative test file to use specific
QuantumPropagators.Controlssymbols.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/derivs.jl |
Implements get_control_deriv method for GuidedAmplitude consistent with ShapedAmplitude. |
test/test_derivs.jl |
Adds a dedicated testset validating GuidedAmplitude derivatives for functional and discretized controls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to JuliaQuantumControl/QuantumPropagators.jl#111