Skip to content

Add derivative for GuidedAmplitude#107

Merged
goerz merged 1 commit intomasterfrom
guided-amplitude-deriv
May 4, 2026
Merged

Add derivative for GuidedAmplitude#107
goerz merged 1 commit intomasterfrom
guided-amplitude-deriv

Conversation

@goerz
Copy link
Copy Markdown
Member

@goerz goerz commented May 4, 2026

@goerz goerz added the enhancement New feature or request label May 4, 2026
@goerz goerz requested a review from Copilot May 4, 2026 17:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.7%. Comparing base (1ece6f0) to head (07998cc).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #107     +/-   ##
========================================
+ Coverage    87.7%   87.7%   +0.1%     
========================================
  Files          20      20             
  Lines        1123    1124      +1     
========================================
+ Hits          984     985      +1     
  Misses        139     139             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds get_control_deriv support for QuantumPropagators.Amplitudes.GuidedAmplitude so gradient/derivative extraction works consistently across amplitude types, following the upstream QuantumPropagators.jl changes.

Changes:

  • Add get_control_deriv(::GuidedAmplitude, control) returning LockedAmplitude(shape) for the matching control.
  • Extend derivative tests to cover GuidedAmplitude, including the discretized-on-tlist constructor case.
  • Tighten/import adjustments in the derivative test file to use specific QuantumPropagators.Controls symbols.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/derivs.jl Implements get_control_deriv method for GuidedAmplitude consistent with ShapedAmplitude.
test/test_derivs.jl Adds a dedicated testset validating GuidedAmplitude derivatives for functional and discretized controls.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@goerz goerz merged commit 5d4e99f into master May 4, 2026
12 checks passed
@goerz goerz deleted the guided-amplitude-deriv branch May 4, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants