You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The parser uses JSON.parse(contents) without a try-catch block. If a .tokens.json file contains malformed JSON, the build process will crash with an unhelpful stack trace instead of a meaningful error message indicating which file failed to parse.
The code destructures components and alpha from token.$value without validating that the value is an object with these properties. If a T1 color token has an unexpected format (e.g., a string reference that slipped through the filter or a malformed value), this will throw a runtime TypeError when attempting to access properties on a primitive.
The indexByName function creates a Map using token names as keys. If multiple tokens share the same name (possible when tokens are defined across multiple files or tiers), later tokens silently overwrite earlier ones in the Map. This can lead to incorrect Swift code generation where some tokens are missing or have wrong values, without any warning to the developer.
The reason will be displayed to describe this comment to others. Learn more.
Issue: please run yarn format and configure your IDE accordingly, we use 2 spaces for tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the final needs to build the needed tokens for swiftUI