Skip to content

chore: Add Style dictionary depedency#68

Draft
lebojo wants to merge 1 commit intomainfrom
feat/ios/build-tokens
Draft

chore: Add Style dictionary depedency#68
lebojo wants to merge 1 commit intomainfrom
feat/ios/build-tokens

Conversation

@lebojo
Copy link
Copy Markdown
Member

@lebojo lebojo commented Mar 24, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

Problem

Issue Number: N/A

Solution

Other information

@lebojo
Copy link
Copy Markdown
Member Author

lebojo commented Mar 24, 2026

Depends on #67 #69 #70

@github-actions
Copy link
Copy Markdown
Contributor

⏭️ Storybook build skipped

  • Reason: pull request is still in draft
  • Changed files inspected: 2
  • Workflow run: View details

Storybook build was intentionally skipped for this PR event.

Relevant files

  • packages/tokens/package.json
  • yarn.lock

@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Dependency Classification

style-dictionary is a build-time tool used to generate platform-specific code from design tokens. Adding it to dependencies instead of devDependencies will cause it to be installed unnecessarily by consumers of this package, increasing their node_modules size and install time. It should be moved to devDependencies unless the package exposes a runtime API that specifically requires this library at execution time.

"dependencies": {
  "style-dictionary": "^5.4.0"
}

Comment on lines +28 to 30
"dependencies": {
"style-dictionary": "^5.4.0"
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Move style-dictionary to devDependencies instead of dependencies. Style Dictionary is a build-time tool used to transform design tokens into platform-specific formats (CSS, SCSS, etc.) and is not needed at runtime. Keeping it in dependencies unnecessarily increases the installation footprint for consumers of this package. [general, importance: 7]

Suggested change
"dependencies": {
"style-dictionary": "^5.4.0"
}
"devDependencies": {
"colorjs.io": "^0.6.1",
"zod": "^4.3.6",
"style-dictionary": "^5.4.0"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant