Skip to content

Ab#74 next#5615

Merged
vesameskanen merged 154 commits intonextfrom
AB#74-next
Jan 9, 2026
Merged

Ab#74 next#5615
vesameskanen merged 154 commits intonextfrom
AB#74-next

Conversation

@vesameskanen
Copy link
Member

@vesameskanen vesameskanen commented Jan 8, 2026

NearYouView refactored:

  • Useless duplicate state removed
  • Split to sub components
  • Function components only
  • Simplify code
  • Rename a lot
  • Refactor a lot
  • No proptype warnings on debugger
  • Several bugs got fixed, for example favorites near you now shows vehicles on map.

Digitransit-component-icon refactored:

  • Duplicate and unused icons removed
  • Icon content optimized
  • Hard coded colors removed (rendering actually obeys iconColor prop)
  • All icons now have consistent understandable name, which allows icon name creation by logic. No need for 200 code line if spagehetti to find an icon.

Digitransit-component-control-panel refactored:

  • Fake and entangled props removed
  • Translations updated
  • Horizontal and vertical layout is now expandable

Digitransit-component-suggestion-item refactored:

  • Thanks to consistent names, complex logic for transport mode related icon names is now much simpler

Lots of other fixes while refactoring (configuration cleanup, MapNearYou refactored, etc.)

New nearyou tabs are already plugged in but they render some existing components. Content and styles need updating.

It does not make sense to prefix everything with 'Stop'
Pass consistent currentTime and tab activation props to child components.
- Remove fake props
- reqeuire all props
- Convert to function component
- Rename and simplify
- Remove useless state, use refs not state
- Simple aria messages
@partisaani
Copy link
Contributor

partisaani commented Jan 9, 2026

Inconsistent padding on index page
image

Current:
image

@vesameskanen
Copy link
Member Author

This PR contains most of required refactoring and the new grapql queries. UI layout is mostly unfinished yet - there will be and expansion button if horizontal row contains too many buttons.

Will be fixed in a new PR.

@partisaani
Copy link
Contributor

image

Info badge is missing colours.

@partisaani
Copy link
Contributor

partisaani commented Jan 9, 2026

image

Parking area cards have a lot of unused blank space in breakpoint >= "large"

@vesameskanen vesameskanen merged commit 85b6d5b into next Jan 9, 2026
1 check passed
@vesameskanen vesameskanen deleted the AB#74-next branch January 9, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants