AB#74 near you view refactoring for v3#5626
Merged
partisaani merged 175 commits intov3from Jan 20, 2026
Merged
Conversation
It does not make sense to prefix everything with 'Stop'
Pass consistent currentTime and tab activation props to child components.
- Remove fake props - reqeuire all props
- Convert to function component - Rename and simplify - Remove useless state, use refs not state - Simple aria messages
Don't redefine a whole jsx block just to change a prop value
Also, remove strange single style prop from config
Also, make onClick callback a required prop and remove other linking methods
Two button types are now unified.
Also, use local train label for HSL.
Also clean up some dead styles
Also, parametrize styles more to get all new layout variants
HSL blue is noi longer hard coded into svg
Next branch CI does not publish npm packages. This commit ensures that correct package versions get published.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest state of near you view and other refactoring changes included in #5623.
Configurations do not add new near you modes, so this change set is mostly invisible in dev and upcoming prod releases (apart from several bug fixes).