fix(firestore-vector-search): backfill embedding model corrected#728
Merged
fix(firestore-vector-search): backfill embedding model corrected#728
Conversation
CorieW
force-pushed
the
@invertase/fix-fvs-backfill
branch
from
3ac2ab7 to
bcf8d88
Compare
CorieW
force-pushed
the
@invertase/fix-fvs-backfill
branch
from
bcf8d88 to
5a194ab
Compare
CorieW
force-pushed
the
@invertase/fix-fvs-backfill
branch
from
5a194ab to
cd651f3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the firestore vector search backfill embedding model by migrating from deprecated embedding models to current ones and consolidating the codebase around the Genkit library. The changes replace the soon-to-be-deprecated textEmbeddingGecko001GoogleAI model with textEmbedding004 as mentioned in the deprecation notice for August.
Key changes include:
- Removal of legacy embedding client implementations (VertexAI and Gemini direct clients)
- Migration to unified Genkit-based embedding approach for all providers
- Update to newer embedding model (
textEmbedding004) replacing the deprecated Gecko model
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vertex_ai.ts | Removed legacy VertexAI embedding client implementation |
| gemini.ts | Removed legacy Gemini AI embedding client implementation |
| index.ts | Refactored to use Genkit client for both gemini and vertex providers |
| genkit.ts | Updated to use newer embedding model and fixed implementation bugs |
| package.json | Updated Genkit dependencies to latest versions |
| genkit.test.ts | Updated test mocks to reflect new embedding model |
| gemini.test.ts | Removed test file for deleted Gemini client |
Files not reviewed (1)
- firestore-vector-search/functions/package-lock.json: Language not supported
firestore-vector-search/functions/src/embeddings/client/genkit.ts
Outdated
Show resolved
Hide resolved
firestore-vector-search/functions/src/embeddings/client/genkit.ts
Outdated
Show resolved
Hide resolved
CorieW
force-pushed
the
@invertase/fix-fvs-backfill
branch
3 times, most recently
from
ee297c9 to
c5ade26
Compare
CorieW
force-pushed
the
@invertase/fix-fvs-backfill
branch
from
c5ade26 to
705effc
Compare
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
andyma-star
pushed a commit
to andyma-star/firebase-extensions
that referenced
this pull request
Mar 12, 2026
…gleCloudPlatform#728) * fix(firestore-vector-search): backfill embedding model corrected * chore(firestore-vector-search): removing some old stuff * chore(firestore-vector-search): adjust changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested
Fixes backfill embedding model
Replaces
textEmbeddingGecko001GoogleAIas soon to deprecate in AugustRemoves some of the old embedding stuff