Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ function WorkspaceMemberDetailsPage({personalDetails, policy, route}: WorkspaceM
const phoneNumber = getPhoneNumber(details);
const reimburserEmail = getReimburserEmail(policy);
const isReimburser = !!reimburserEmail && reimburserEmail === memberLogin;
const canEditSelectedMemberRole = !isSelectedMemberOwner && !isSelectedMemberCurrentUser && !isReimburser && canManageSelectedMemberRole;
const {isAccountLocked} = useLockedAccountState();
const {showLockedAccountModal} = useLockedAccountActions();

Expand Down Expand Up @@ -378,11 +379,13 @@ function WorkspaceMemberDetailsPage({personalDetails, policy, route}: WorkspaceM
copyable
/>
<MenuItemWithTopDescription
disabled={isSelectedMemberOwner || isSelectedMemberCurrentUser || !canManageSelectedMemberRole}
disabled={!canEditSelectedMemberRole}
title={translate(`workspace.common.roleName`, member?.role)}
interactive={!isReimburser && canManageSelectedMemberRole}
interactive={canEditSelectedMemberRole}
description={translate('common.role')}
shouldShowRightIcon={!isReimburser && canManageSelectedMemberRole}
shouldShowRightIcon={canEditSelectedMemberRole}
shouldGreyOutWhenDisabled={false}
shouldUseDefaultCursorWhenDisabled
pressableTestID="member-role-menu-item"
onPress={() => {
if (
Expand Down
19 changes: 18 additions & 1 deletion tests/ui/WorkspaceMemberDetailsPageTest.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {act, fireEvent, render, screen, waitFor} from '@testing-library/react-native';
import {act, fireEvent, render, screen, waitFor, within} from '@testing-library/react-native';

import ComposeProviders from '@components/ComposeProviders';
import HTMLEngineProvider from '@components/HTMLEngineProvider';
Expand Down Expand Up @@ -235,4 +235,21 @@ describe('WorkspaceMemberDetailsPage', () => {
unmount();
await waitForBatchedUpdatesWithAct();
});

it('should render the read-only role of the owner at full opacity and without a caret', async () => {
const {unmount} = renderPage({policyID: policy.id, accountID: String(ownerAccountID)});
await waitForBatchedUpdatesWithAct();

const roleItem = await screen.findByTestId('member-role-menu-item');

// The owner's role stays disabled so the edit flow cannot be opened...
expect(roleItem).toBeDisabled();

// ...but it must not be dimmed or keep the caret, so it matches the other read-only fields.
expect(roleItem).not.toHaveStyle({opacity: 0.5});
expect(within(roleItem).queryByTestId('ArrowRight Icon')).not.toBeOnTheScreen();

unmount();
await waitForBatchedUpdatesWithAct();
});
});
Loading