fix: display read-only Role selector at full opacity in member details - #98109
Open
mukhrr wants to merge 2 commits into
Open
fix: display read-only Role selector at full opacity in member details#98109mukhrr wants to merge 2 commits into
mukhrr wants to merge 2 commits into
Conversation
Gate disabled/interactive/shouldShowRightIcon on a single canEditSelectedMemberRole flag and pass shouldGreyOutWhenDisabled={false} + shouldUseDefaultCursorWhenDisabled, so the read-only Role field renders at full opacity with no caret and a default cursor, matching the Email field.
melvin-bot
Bot
requested review from
JmillsExpensify and
eVoloshchak
and removed request for
a team
August 10, 2026 01:22
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The Role field in the member details panel was passed
disabled, andMenuItemdims any disabled row toopacity: 0.5, so a read-only role looked greyed out.interactive/shouldShowRightIconused a different condition that ignored the owner and current-user cases, so the caret could still show.Now a single
canEditSelectedMemberRoleflag drivesdisabled,interactiveandshouldShowRightIcon, plusshouldGreyOutWhenDisabled={false}andshouldUseDefaultCursorWhenDisabled. The press guard stays, and the read-only Role field renders at full opacity, with no caret and a default cursor, matching the Email field.Fixed Issues
$ #96791
PROPOSAL: #96791 (comment)
Tests
>) is displayed on the Role row, and hovering it shows the normal cursor, so it looks the same as the read-only Email field above it.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_app.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios_app.mp4
iOS: mWeb Safari
ios_web.mp4
MacOS: Chrome / Safari
web.mp4