Skip to content

fix: display read-only Role selector at full opacity in member details - #98109

Open
mukhrr wants to merge 2 commits into
Expensify:mainfrom
mukhrr:fix/96791
Open

fix: display read-only Role selector at full opacity in member details#98109
mukhrr wants to merge 2 commits into
Expensify:mainfrom
mukhrr:fix/96791

Conversation

@mukhrr

@mukhrr mukhrr commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The Role field in the member details panel was passed disabled, and MenuItem dims any disabled row to opacity: 0.5, so a read-only role looked greyed out. interactive / shouldShowRightIcon used a different condition that ignored the owner and current-user cases, so the caret could still show.

Now a single canEditSelectedMemberRole flag drives disabled, interactive and shouldShowRightIcon, plus shouldGreyOutWhenDisabled={false} and shouldUseDefaultCursorWhenDisabled. The press guard stays, and the read-only Role field renders at full opacity, with no caret and a default cursor, matching the Email field.

Fixed Issues

$ #96791
PROPOSAL: #96791 (comment)

Tests

  1. Sign in as a workspace admin who is not the workspace owner.
  2. Go to Workspace > Members.
  3. Click the Owner to open the member details panel.
  4. Verify the Role field is displayed at full opacity (not dimmed / not greyed out).
  5. Verify no caret (>) is displayed on the Role row, and hovering it shows the normal cursor, so it looks the same as the read-only Email field above it.
  6. Click the Role row and verify nothing happens (it does not open the role page).
  7. Open a member whose role you can change (e.g. a Member/Employee) and verify that row still shows the caret, is clickable, and opens the role page as before.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Repeat the steps above and verify the Role field renders identically (full opacity, no caret for read-only members, caret and navigation for editable members). This is a presentation-only change, so behaviour is unchanged offline.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_app.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios_app.mp4
iOS: mWeb Safari
ios_web.mp4
MacOS: Chrome / Safari
web.mp4

mukhrr added 2 commits August 10, 2026 06:16
Gate disabled/interactive/shouldShowRightIcon on a single canEditSelectedMemberRole flag and pass shouldGreyOutWhenDisabled={false} + shouldUseDefaultCursorWhenDisabled, so the read-only Role field renders at full opacity with no caret and a default cursor, matching the Email field.
@mukhrr
mukhrr requested review from a team as code owners August 10, 2026 01:22
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and eVoloshchak and removed request for a team August 10, 2026 01:22
@melvin-bot

melvin-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant