Add package to evaluate the impact of the beam skipping feature in nav2#116
Draft
Add package to evaluate the impact of the beam skipping feature in nav2#116
Conversation
hidmic
reviewed
Oct 31, 2024
Collaborator
There was a problem hiding this comment.
This is great! Two thoughts.
- We can but we don't necessarily have to add another package for a different benchmark. We can accumulate benchmarks in a single package too.
- Tied to the above, eventually I would very much like to move Beluga benchmarks to Beluga. Putting all benchmarks in a single package will simplify that transition while keeping the Beluga repo sane. Either that or we have to start considering a separate Beluga benchmarks repository.
| - Description | ||
| * - `Willow Garage dataset <https://web.archive.org/web/20151207202459id_/http://cgi.cs.duke.edu/~mac/papers/iros12_sm.pdf>`_ | ||
| - Large office environment with multiple recordings along different trajectories and times, including multiple rooms and hallways. | ||
| * - `TorWIC SLAM dataset <https://github.com/Viky397/TorWICDataset>`_ |
21ae1dd to
1df7924
Compare
Collaborator
Author
This is not necesarily intended to merge. It's just a quick and dirty benchmark draft to share with @DPR00 to get him up to speed with Ekumen-OS/beluga#187 , sparing him hitting the learning curve head on . We can later decide what we want to do with this. |
1df7924 to
54e0742
Compare
54e0742 to
816ba4b
Compare
7c1ef77 to
f657f40
Compare
1d84157 to
4a2fffa
Compare
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
4a2fffa to
68382e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Crude benchmark package to compare nav2-vs-nav2, likelihood vs likelihood_prob vs beam_skip.
This is part of a fact finding campaing for Ekumen-OS/beluga#187 .
Type of change
💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.
Checklist
Put an
xin the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
Anything worth mentioning to the reviewers.