Fix insane aztec torso resist values#86520
Closed
BruhddyTheThird wants to merge 10 commits intoCleverRaven:masterfrom
Closed
Fix insane aztec torso resist values#86520BruhddyTheThird wants to merge 10 commits intoCleverRaven:masterfrom
BruhddyTheThird wants to merge 10 commits intoCleverRaven:masterfrom
Conversation
jsonstyle compliance Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
This PR and #86518 both address the same bug report. Mergers ought to check if they compete with each other or are complementary before merging. |
Contributor
Author
|
Sorry about that, thats what I get for making PRs before bed 😅, I'll close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Reduce aztec vest resist values"
Purpose of change
To close #86499. Currently, the "Ichcahuipilli" torso armor piece has values of 30+ in all resist, which for armor that can be made from cloth and leather, is insane. Not only is my change aiming to fix that, but I would like to give some reasonable changes to the armor piece aside from just the resist values, and add a material that might be useful for implementing future padded cotton armors.
Describe the solution
First, we make a new material,
"id": "cotton_raw", which has some very low resist values; the values are in the sub-integer range, so it takes a lot of material to create a decent amount of resist. Then, using some first and secondhand accounts of Spanish conquistadors, along with some more academic sources, we get an idea for the properties of the material/construction of the vest, how it feels, and its protective capabilities. We then tweak the materials and stats of the vest to be reasonable (shown in testing), do some math, and tweak the recipe + comments to match reality/ a balanced state.Some of these properties are:
Describe alternatives you've considered
Testing
Made a debug world with the changes, spawned in the armor,

examined it, it has normal protection values, and the new material "Raw Cotton".Additional context
If someone who has more tailoring knowledge than me can give better values for what the armor construction should look like, I'd be all ears, because I don't have a lot of background in the field there, and same goes for if someone can give more elucidating firsthand accounts and/or historical evidence of differences in the recipe/stats.