Skip to content

chore: remove tracing-chrome feature#6681

Merged
hanabi1224 merged 5 commits intomainfrom
rm-tracing-chrome
Mar 3, 2026
Merged

chore: remove tracing-chrome feature#6681
hanabi1224 merged 5 commits intomainfrom
rm-tracing-chrome

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Mar 3, 2026

Summary of changes

Changes introduced in this pull request:

  • removed (most likely) unused tracing-chrome feature

Reference issue to close (if applicable)

Closes

Other information and links

on top of #6680 which needs to be merged first

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Breaking Changes
    • Removed the tracing-chrome feature; it is no longer available by default. If you relied on CHROME_TRACE_FILE tracing, update workflows accordingly.
  • Documentation
    • Removed the Cargo Features section from documentation and updated changelog entries to reflect the feature removal.
  • Chores
    • Simplified logger behavior to no longer include the tracing-chrome integration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd7901 and 6bf2cb6.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • AGENTS.md
  • CHANGELOG.md
  • Cargo.toml
💤 Files with no reviewable changes (1)
  • AGENTS.md

Walkthrough

Removed the tracing-chrome feature and its Chrome-tracing integration, updated default features in Cargo.toml (dropped tracing-chrome), simplified setup_logger to return only background tasks, and updated logger call sites to match the new signature. Documentation and changelog entries updated accordingly.

Changes

Cohort / File(s) Summary
Configuration & Documentation
AGENTS.md, CHANGELOG.md, Cargo.toml
Removed tracing-chrome feature from docs and changelog; updated Cargo.toml to remove tracing-chrome optional dependency and drop it from default features; reordered/adjusted feature group declarations and allocator entries.
Logger Module
src/cli_shared/logger/mod.rs
Removed Guards type and Chrome tracing setup (CHROME_TRACE_FILE handling and tracing-chrome integration); changed setup_logger signature to return only Vec<BackgroundTask> and removed guards-related logic.
Logger Call Sites
src/cli/main.rs, src/daemon/main.rs
Updated logger initialization to accept single return (background tasks) from setup_logger instead of destructuring a tuple with guards.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • akaladarshi
  • sudo-shashank
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the tracing-chrome feature from the codebase, which is reflected across all modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rm-tracing-chrome

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review March 3, 2026 10:22
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner March 3, 2026 10:22
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team March 3, 2026 10:22
@LesnyRumcajs LesnyRumcajs changed the title Rm tracing chrome chore: rm tracing chrome Mar 3, 2026
@LesnyRumcajs LesnyRumcajs changed the title chore: rm tracing chrome chore: remove tracing-chrome feature Mar 3, 2026
hanabi1224
hanabi1224 previously approved these changes Mar 3, 2026
@hanabi1224 hanabi1224 enabled auto-merge March 3, 2026 10:27
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@AGENTS.md`:
- Line 360: The AGENTS.md default feature list is out of sync with Cargo.toml —
update the "**`default`** - `jemalloc`, `tracing-loki`" entry to include
`sqlite` so it matches the crate's default features; locate the string literal
in AGENTS.md and add `sqlite` to that comma-separated list (verify against the
`default` features block in Cargo.toml to ensure exact spelling and ordering).

In `@CHANGELOG.md`:
- Line 30: Update the two changelog entries that currently read like "-
[`#6680`](https://...)" (and the other entry at the same pattern) to follow the
documented format by inserting a colon and space after the linked PR number,
i.e. change "- [`#6680`](...)" to "- [`#6680`](...): " so each entry uses the
required ": " separator as described at the top of CHANGELOG.md.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bad9cb1 and 9fd7901.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • AGENTS.md
  • CHANGELOG.md
  • Cargo.toml
  • src/cli/main.rs
  • src/cli_shared/logger/mod.rs
  • src/daemon/main.rs

@hanabi1224 hanabi1224 added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit f038322 Mar 3, 2026
43 checks passed
@hanabi1224 hanabi1224 deleted the rm-tracing-chrome branch March 3, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants