chore!: remove tracing-chrome feature

Author: LesnyRumcajs

AGENTS.md

@@ -357,15 +357,14 @@ lldb target/debugging/forest
 
 ## Cargo Features
 
-- **`default`** - `jemalloc`, `tokio-console`, `tracing-loki`, `tracing-chrome`
+- **`default`** - `jemalloc`, `tracing-loki`
 - **`test`** - Default feature set for unit tests
 - **`slim`** - Minimal feature set (uses rustalloc)
 - **`jemalloc`** - Use jemalloc allocator (production default)
 - **`rustalloc`** - Use Rust standard allocator
 - **`system-alloc`** - Use system allocator (for memory profiling)
 - **`tokio-console`** - Enable tokio-console integration
 - **`tracing-loki`** - Send telemetry to Loki
-- **`tracing-chrome`** - Chrome tracing support
 - **`no-f3-sidecar`** - Disable F3 sidecar build
 - **`cargo-test`** - Group of tests that is recommended to run with `cargo test` instead of `nextest`
 - **`doctest-private`** - Enable doctests for private items

CHANGELOG.md

@@ -35,6 +35,8 @@
 
 ### Removed
 
+- [#xxxx](xxx) Removed `tracing-chrome` feature and all related code as it was deemed unused. If you didn't set `CHROME_TRACE_FILE` manually before, you shouldn't be affected by this change. If you were using this feature, reach out.
+
 ### Fixed
 
 ## Forest v0.32.3 "Unimpressive Serenity"

Cargo.lock

@@ -230,7 +230,6 @@ zstd = "0.13"
 console-subscriber = { version = "0.5", features = ["parking_lot"], optional = true }
 sqlx = { version = "0.8", default-features = false, features = ["sqlite", "runtime-tokio", "macros"], optional = true }
 tikv-jemallocator = { version = "0.6", optional = true }
-tracing-chrome = { version = "0.7", optional = true }
 tracing-loki = { version = "0.2", default-features = false, features = ["compat-0-2-1", "rustls"], optional = true }
 
 [target.'cfg(unix)'.dependencies]
@@ -320,13 +319,13 @@ lto = "fat"
 
 # These should be refactored (probably removed) in #2984
 [features]
-default = ["jemalloc", "tracing-loki", "tracing-chrome", "sqlite"]
-test = []                                                                           # default feature set for unit tests
+default = ["jemalloc", "tracing-loki", "sqlite"]
+test = []                                        # default feature set for unit tests
 slim = ["rustalloc"]
-cargo-test = []                                                                     # group of tests that is recommended to run with `cargo test` instead of `nextest`
-doctest-private = []                                                                # see lib.rs::doctest_private
-benchmark-private = ["dep:criterion"]                                               # see lib.rs::benchmark_private
-interop-tests-private = []                                                          # see lib.rs::interop_tests_private
+cargo-test = []                                  # group of tests that is recommended to run with `cargo test` instead of `nextest`
+doctest-private = []                             # see lib.rs::doctest_private
+benchmark-private = ["dep:criterion"]            # see lib.rs::benchmark_private
+interop-tests-private = []                       # see lib.rs::interop_tests_private
 sqlite = ["dep:sqlx"]
 
 # Allocator. Use at most one of these.
@@ -336,7 +335,6 @@ system-alloc = []                    # Use the platform allocator (for memory pr
 
 tokio-console = ["dep:console-subscriber"]
 tracing-loki = ["dep:tracing-loki"]
-tracing-chrome = ["dep:tracing-chrome"]
 
 no-f3-sidecar = []
 

Cargo.toml

@@ -28,7 +28,7 @@ where
 
     let client = rpc::Client::default_or_from_env(token.as_deref())?;
 
-    let (_bg_tasks, _guards) = logger::setup_logger(&crate::cli_shared::cli::CliOpts::default());
+    let _bg_tasks = logger::setup_logger(&crate::cli_shared::cli::CliOpts::default());
 
     cmd.run(client).await
 }

src/cli/main.rs

@@ -11,16 +11,9 @@ use crate::utils::misc::LoggingColor;
 
 type BackgroundTask = Pin<Box<dyn Future<Output = ()> + Send>>;
 
-#[derive(Default)]
-pub struct Guards {
-    #[cfg(feature = "tracing-chrome")]
-    tracing_chrome: Option<tracing_chrome::FlushGuard>,
-}
-
 #[allow(unused_mut)]
-pub fn setup_logger(opts: &CliOpts) -> (Vec<BackgroundTask>, Guards) {
+pub fn setup_logger(opts: &CliOpts) -> Vec<BackgroundTask> {
     let mut background_tasks: Vec<BackgroundTask> = vec![];
-    let mut guards = Guards::default();
     let mut layers: Vec<Box<dyn tracing_subscriber::layer::Layer<Registry> + Send + Sync>> =
         // console logger
         vec![Box::new(
@@ -88,30 +81,8 @@ pub fn setup_logger(opts: &CliOpts) -> (Vec<BackgroundTask>, Guards) {
         }
     }
 
-    // Go to <https://ui.perfetto.dev> to browse trace files.
-    // You may want to call ChromeLayerBuilder::trace_style as appropriate
-    if let Some(_chrome_trace_file) = std::env::var_os("CHROME_TRACE_FILE") {
-        #[cfg(not(feature = "tracing-chrome"))]
-        tracing::warn!(
-            "`tracing-chrome` is unavailable, forest binaries need to be recompiled with `tracing-chrome` feature"
-        );
-
-        #[cfg(feature = "tracing-chrome")]
-        {
-            let (layer, guard) = match _chrome_trace_file.is_empty() {
-                true => tracing_chrome::ChromeLayerBuilder::new().build(),
-                false => tracing_chrome::ChromeLayerBuilder::new()
-                    .file(_chrome_trace_file)
-                    .build(),
-            };
-
-            guards.tracing_chrome = Some(guard);
-            layers.push(Box::new(layer));
-        }
-    }
-
     tracing_subscriber::registry().with(layers).init();
-    (background_tasks, guards)
+    background_tasks
 }
 
 // Log warnings to stderr

src/cli_shared/logger/mod.rs

@@ -35,7 +35,7 @@ where
     // Run forest as a daemon if no other subcommands are used. Otherwise, run the
     // subcommand.
 
-    let (background_tasks, _guards) = logger::setup_logger(&opts);
+    let background_tasks = logger::setup_logger(&opts);
 
     if let Some(path) = &path {
         match path {