fix(upgrade): run script installer pipeline via shell#292
Open
zerone0x wants to merge 1 commit into
Open
Conversation
Fixes zzet#281 Co-Authored-By: bridge <bridge@nousresearch.com>
zzet
previously approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #281
gortex upgrade --runnow executes the installer-script command throughsh -c, so the documented installer pipeline is interpreted by a shell instead of being split into raw curl arguments.Changes
upgradeExecCommandto choose shell execution only for commands with shell metacharactersgo install ...go installpathValidation
gofmt -w cmd/gortex/upgrade.go cmd/gortex/upgrade_test.go— blocked: this runner does not havegofmt/Go installed