_git: fix --git-dir and --work-tree options when used with parameters#156
Open
baodrate wants to merge 1 commit intozsh-users:masterfrom
Open
_git: fix --git-dir and --work-tree options when used with parameters#156baodrate wants to merge 1 commit intozsh-users:masterfrom
baodrate wants to merge 1 commit intozsh-users:masterfrom
Conversation
`_arguments` sets opt_args with the un-expanded values from the command line.
So the `GIT_DIR`/`GIT_WORK_TREE` environment variables are set non-functional
when those options contain parameters. e.g.:
```zsh
expand-or-complete
opt_args=(
[--git-dir]='$HOME/.dotfiles'
[--work-tree]='$HOME'
)
...
local -x GIT_DIR='$HOME/.dotfiles'
local -x GIT_WORK_TREE='$HOME'
files=(${(0)"$(_call_program files git ...)"})
fatal: not a git repository: '$HOME/.dotfiles'
```
Expand these two opts when setting so that they function as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_argumentssets opt_args with the un-expanded values from the command line. So theGIT_DIR/GIT_WORK_TREEenvironment variables are set non-functional when those options contain parameters. e.g.:Expand these two opts when setting so that they function as intended.