support left shift or right shift operator#241
Closed
Lynette7 wants to merge 2 commits into
Closed
Conversation
Contributor
|
Thanks for addressing this. I realized this feature can be complicated to support in the constraint level, because the unit in that level is finite field. It makes sense to support logical shifting in finite field, but that can be confusing from user perspective since they might assume they are arithmetic shifting. Therefore, I think for now we can just make it support in the hint function. That is the feature can be implemented in the Also please add tests in the examples. |
Contributor
|
This feature for hint functions has been implemented in another PR #253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #181
To implement right-shift and left-shift operators, here are the changes I've made:
<<and>>in the lexerOp2enum to includeRightShiftandLeftShift