fix: Simplify sightline algorithm and fix asymmetry#724
Open
jprzimba wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the previous Xiaolin Wu based sight-line tracing with a simpler integer-stepping approach using line coefficients (a, b, c) and explicit stepX/stepY decisions.
The new loop advances along the major/minor directions by comparing move costs and checks tiles for CONST_PROP_BLOCKPROJECTILE as it goes.
Also update isSightClear to try the reverse ray when on the same floor and the forward check fails to handle asymmetric corner cases.
This simplifies the code, reduces special-case branches (horizontal/vertical), and fixes sight asymmetry around solid tiles. Related issue #709