fix: validate amount before removing value from players bank#122
Draft
jpaulooliveira wants to merge 1 commit into
Draft
fix: validate amount before removing value from players bank#122jpaulooliveira wants to merge 1 commit into
jpaulooliveira wants to merge 1 commit into
Conversation
jprzimba
changed the title
jprzimba
changed the title
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a validation function (
validRemoveMoney) to ensure the value being removed is valid before completing the transaction.This fixes a bug where players could buy items from NPCs without sufficient funds. The issue appears to stem from a mismatch in total value calculation in the NPC trade window, allowing purchases without the required money.
The original
removeMoneylogic was copied and adjusted invalidRemoveMoneyto properly validate the transaction beforehand.