Problem: test for gossip is based on endpoint address instead of actual actor, causing untimely unpublish message#752
Merged
sphaero merged 1 commit intozeromq:masterfrom Feb 3, 2026
Conversation
…al actor, causing untimely unpublish message Solution: use the actor instead
Contributor
|
Are you sure you are right? There are some other issues in the tests as well. |
Contributor
Author
|
@sphaero I do not think my PR has something to do with UNPUBLISH being unknown. Maybe the tests do not include draft APIs. I managed to conduct the tests on a Debian machine and they went well, just like on macos. It is likely that something is broken in the test infrastructure rather than in the code. |
Contributor
|
Yeah I noticed the tests failing on other PRs as well. It's always a cat and mouse game with the tests. I don't have any projects utilizing Zyre currently so my effort is limited but the tests really need some tender love and care. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: use the actor instead