Skip to content

Problem: test for gossip is based on endpoint address instead of actual actor, causing untimely unpublish message#752

Merged
sphaero merged 1 commit intozeromq:masterfrom
stvales:unpublish
Feb 3, 2026
Merged

Problem: test for gossip is based on endpoint address instead of actual actor, causing untimely unpublish message#752
sphaero merged 1 commit intozeromq:masterfrom
stvales:unpublish

Conversation

@stvales
Copy link
Contributor

@stvales stvales commented Jan 31, 2026

Solution: use the actor instead

…al actor, causing untimely unpublish message

Solution: use the actor instead
@sphaero
Copy link
Contributor

sphaero commented Feb 2, 2026

Are you sure you are right?

* zyre_election: E: 26-01-31 15:09:29 unknown zgossip method 'UNPUBLISH'
OK
 * zyre_node: OK
 * zyre: E: 26-01-31 15:09:29 unknown zgossip method 'UNPUBLISH'
*** buffer overflow detected ***: terminated

There are some other issues in the tests as well.

@stvales
Copy link
Contributor Author

stvales commented Feb 2, 2026

@sphaero I do not think my PR has something to do with UNPUBLISH being unknown. Maybe the tests do not include draft APIs. I managed to conduct the tests on a Debian machine and they went well, just like on macos. It is likely that something is broken in the test infrastructure rather than in the code.

@sphaero
Copy link
Contributor

sphaero commented Feb 3, 2026

Yeah I noticed the tests failing on other PRs as well. It's always a cat and mouse game with the tests. I don't have any projects utilizing Zyre currently so my effort is limited but the tests really need some tender love and care.

@sphaero sphaero merged commit e25cf6f into zeromq:master Feb 3, 2026
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants