Store zmq_timers_timeout() result in long, not int#681
Merged
gummif merged 1 commit intozeromq:masterfrom Mar 13, 2026
Merged
Conversation
[why]
When compiling with -Wconversion, gcc 13.3 issues a warning:
zmq.hpp: In member function ‘zmq::timers::timeout_result_t zmq::timers::timeout() const’:
zmq.hpp:2857:41: warning: conversion from ‘long int’ to ‘int’ may change value [-Wconversion]
2857 | int timeout = zmq_timers_timeout(_timers);
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~
zmq_timers_timeout() returns long, but its return value is stored in an
int variable, which may or may not be a mismatch depending on compiler
and architecture.
[how]
Simply adjust the type of the variable from int to long. We could also
change the literal in the following comparison from -1 to -1L, but that
seems pedantic and does not match the style of the surrounding code.
Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
Pull Request Test Coverage Report for Build 23043522058Details
💛 - Coveralls |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[why]
When compiling with
-Wconversion, gcc 13.3 issues a warning:zmq_timers_timeout() returns long, but its return value is stored in an int variable, which may or may not be a mismatch depending on compiler and architecture.
[how]
Simply adjust the type of the variable from int to long. We could also change the literal in the following comparison from -1 to -1L, but that seems pedantic and does not match the style of the surrounding code.