Remove space in custom string literal#652
Merged
gummif merged 1 commit intozeromq:masterfrom Mar 12, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 13804398584Details
💛 - Coveralls |
Member
|
We probably need to modify the clang-format file/update clang-format so this doesn't get reverted, but this is fine for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may lack sufficient context for this to be a useful PR, so please feel free to close if this is not welcome.
For no particular reason I saw an analogous PR to another R package repo in my GitHub home page:
marzer/tomlplusplus#263
I searched the main R package repo for other similarly-affected packages, which includes {clustermq}, which bundles this repo as a submodule:
https://github.com/mschubert/clustermq/tree/master/src
Here's the documentation I could find about why this matters:
https://en.cppreference.com/w/cpp/language/user_literal