Skip to content

Feat/edu#8

Merged
timkalan merged 9 commits into
masterfrom
feat/edu
Jun 17, 2026
Merged

Feat/edu#8
timkalan merged 9 commits into
masterfrom
feat/edu

Conversation

@timkalan

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new projects feature with CRUD routes, migrates the database schema to use UUIDs, and implements a typed Hono RPC client wrapper (hcQueryTyped) on the frontend with custom error handling. Feedback on these changes highlights several critical issues: a runtime/compilation error in the Drizzle schema where a SQL fragment is incorrectly passed to .$onUpdate(), a potential crash in the frontend demo component when handling non-API errors, a JSON parsing vulnerability in safeFetch for empty or non-JSON responses, and a violation of the project's internationalization standards due to hardcoded strings.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread server/database/schema/app.ts
Comment thread web/components/projects-demo.tsx
Comment thread web/lib/typed-client.ts
Comment thread web/components/projects-demo.tsx

@vucinatim vucinatim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread web/lib/api-error.ts Outdated
Comment thread web/lib/typed-client.ts
Comment thread server/server.ts
Comment thread server/database/migrations/0000_empty_alice.sql
@timkalan timkalan merged commit 9348925 into master Jun 17, 2026
6 checks passed
@timkalan timkalan deleted the feat/edu branch June 17, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants