eva-summary.xsl: guard against division by zero when ac or pv is zero#709
Merged
Merged
Conversation
Contributor
Author
|
@yegor256 plz review |
|
@VasilevNStas Thanks for the contribution! You've earned +20 points for this: +24 as a basis; -4 for too few (2) hits-of-code. Please, keep them coming. Your running score is +3000; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #685
Added
and xs:double(ac) != 0 and xs:double(pv) != 0to the template match predicate. Without this guard,ev div acorev div pvproducesINFin XPath 2.0 when the divisor is zero, which crashesformat-number()inz:format-signed.When
acorpvis zero, the template no longer matches and falls through to the low-priority fallback template ("Not enough data..."), which is a safe degradation.