#576 Escape single quotes in query interpolation#615
Open
VasilevNStas wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
@yegor256 plz review this PR |
Member
|
@VasilevNStas why no tests? |
VasilevNStas
commented
Jul 17, 2026
Contributor
Author
There was a problem hiding this comment.
@yegor256
You are right, my apologies. Added tests for area and judge with single quotes in both files.
VasilevNStas
commented
Jul 17, 2026
VasilevNStas
left a comment
VasilevNStas
left a comment
Contributor
Author
There was a problem hiding this comment.
You are right, my apologies. Added tests for area and judge with single quotes in both files.
Contributor
Author
|
@yegor256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Factbase query strings are built via string interpolation with user-supplied values (
area,judge). If these contain a single quote ('), the query syntax breaks, allowing query injection.Solution
Doubled single quotes (
"''") in all user-supplied values interpolated into query strings, matching SQL-style escaping:regularly.rb:areaandjudgein queriesrepeatedly.rb:areaandjudgein all 4 queriesNumeric values (
interval,hours) and bare identifiers (p_every_days,p_every_hours) are not affected since they don't appear inside quoted strings.Closes #576