#578 Guard division by zero in Award calc#613
Merged
Conversation
Contributor
Author
|
@yegor256 plz review |
Member
|
@VasilevNStas no test? |
VasilevNStas
commented
Jul 17, 2026
Contributor
Author
There was a problem hiding this comment.
@yegor256
Test added: test_division_by_zero_raises_error asserts that (div 10 0) raises Fbe::Error.
please re-review this PR
|
@VasilevNStas Thanks for the contribution! You've earned +20 points for this: +24 as a basis; -4 for too few (9) hits-of-code. Please, keep them coming. Your running score is +3428; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
(div n 0)is evaluated in an award expression, Ruby raisesZeroDivisionErrorwhich is not caught and results in a 500-style crash with an unhelpful message.Solution
Added a guard in the
:divbranch ofBTerm#calc: if the divisor is zero, a descriptiveFbe::Erroris raised instead of letting the rawZeroDivisionErrorpropagate.Closes #578