#579 Validate variable substitution in Award text#612
Open
VasilevNStas wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@yegor256 plz review |
Member
|
@VasilevNStas no test? |
VasilevNStas
commented
Jul 17, 2026
Member
|
@VasilevNStas conflicts here |
Contributor
Author
|
@yegor256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
${var}is used in award or bylaw text, an undefined variable silently producesnilor"**nil**"in the output, hiding configuration errors.Solution
Both
Bill#lineandBylaw#linenow check that the variable exists viakey?before substitution. If undefined, a descriptiveFbe::Erroris raised with the variable name and the failing text.Closes #579