Fix memory leak in ZenWorkspaces by adding event listener cleanup#12285
Open
JorySeverijnse wants to merge 4 commits intozen-browser:devfrom
Open
Fix memory leak in ZenWorkspaces by adding event listener cleanup#12285JorySeverijnse wants to merge 4 commits intozen-browser:devfrom
JorySeverijnse wants to merge 4 commits intozen-browser:devfrom
Conversation
JorySeverijnse
commented
Feb 7, 2026
JorySeverijnse
commented
- Store bound event listeners as instance properties for later removal
- Add cleanup() method with (_cleanupDone flag)
- Remove all window listeners (TabOpen/Close/Select, resize, AppCommand, etc.)
- Remove workspace-bookmarks-updated observer
- Uses unload event
- Also fixes RefPtr assignment in ZenStyleSheetCache
- Store bound event listeners as instance properties for later removal - Add cleanup() method with (_cleanupDone flag) - Remove all window listeners (TabOpen/Close/Select, resize, AppCommand, etc.) - Remove workspace-bookmarks-updated observer - Uses unload event - Also fixes RefPtr assignment in ZenStyleSheetCache
dosubot
bot
added
size:M
mr-cheffy
requested changes
Feb 7, 2026
Add closing bracket (i accidentally removed) which otherwise would cause code to break Signed-off-by: Jory Severijnse <jory@severijnse.eu>
revert back to previous were mModsSheet is null on LoadSheetSync failure Signed-off-by: Jory Severijnse <jory@severijnse.eu>
Author
|
Should be good now? Have also built the browser myself (from dev branch with my changes) without any issues |
- Use local consts with inline unload listeners instead of instance properties - Keep bookmarks observer pattern with dedicated unload block - Remove unnecessary _cleanupDone guard from cleanup() - Minimal cleanup() only for listeners that can't use local closures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.