Automate cleanup of unsigned and stale draft pull requests - #62936
Open
zelenenka wants to merge 4 commits into
Open
Automate cleanup of unsigned and stale draft pull requests#62936zelenenka wants to merge 4 commits into
zelenenka wants to merge 4 commits into
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
SomeoneToIgnore
approved these changes
Aug 20, 2026
SomeoneToIgnore
left a comment
SomeoneToIgnore
left a comment
Contributor
There was a problem hiding this comment.
LGTM, not versed enough in Python though.
MrSubidubi
reviewed
Aug 20, 2026
| ) | ||
| if warning_at is not None: | ||
| if now - warning_at >= DRAFT_CLOSE_AFTER_WARNING: | ||
| return "close" |
Member
There was a problem hiding this comment.
Could also make this an enum I suppose
Comment on lines
+405
to
+406
| post_comment(number, DRAFT_CLOSE_COMMENT, dry_run) | ||
| close_pull_request(number, dry_run) |
Member
There was a problem hiding this comment.
Curious here why the comment only happens under that certain circumstance?
Contributor
Author
There was a problem hiding this comment.
removed some of this nonsense in a follow-up commit
Member
|
Also Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
It works on my machine™
Release Notes: