Skip to content

FeaturePanel: Add coloring for opening times to indicate state#1141

Merged
zbycz merged 7 commits intozbycz:masterfrom
homtec:feature-colored-opening-times
Apr 17, 2026
Merged

FeaturePanel: Add coloring for opening times to indicate state#1141
zbycz merged 7 commits intozbycz:masterfrom
homtec:feature-colored-opening-times

Conversation

@homtec
Copy link
Copy Markdown
Contributor

@homtec homtec commented Jul 5, 2025

Description

See at one glance if the POI is open or closed by setting appropriate colors.

Example links

Screenshots

image

Checklist

  • dark mode / light mode
  • mobile / desktop
  • server-side-rendering (SSR)
  • all texts are localized (in vocabulary.ts)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
osmapp Ready Ready Preview Apr 17, 2026 6:57am
osmapp-preview Ready Ready Preview Apr 17, 2026 6:57am

@homtec homtec changed the title add coloring for opening times to indicate state FeaturePanel: Add coloring for opening times to indicate state Jul 5, 2025
@Dlurak
Copy link
Copy Markdown
Collaborator

Dlurak commented Jul 9, 2025

Good idea and thanks for making the effort to implement it 👍

But I think the colour is a bit too prominent/pushy, maybe only show the word coloured and not the time, so for example only the "Closed now" or "Opens soon"...
What do you think?

@homtec
Copy link
Copy Markdown
Contributor Author

homtec commented Jul 10, 2025

Agree, will change it. 👍

@homtec
Copy link
Copy Markdown
Contributor Author

homtec commented Oct 20, 2025

Ready to rumble

@homtec
Copy link
Copy Markdown
Contributor Author

homtec commented Oct 22, 2025

Good idea and thanks for making the effort to implement it 👍

But I think the colour is a bit too prominent/pushy, maybe only show the word coloured and not the time, so for example only the "Closed now" or "Opens soon"... What do you think?

Okay, I’ve updated it as requested, @Dlurak!

@zbycz
Copy link
Copy Markdown
Owner

zbycz commented Nov 4, 2025

Hi, i clicked around the app. And this usecase doesn't look good to me. I guess that only the "Closed now" part should be colored in this case. (The amenity is closed, but it will be opened later that day)

image

I am not sure it is worth updating the code and all the translations properly, but I leave the decision up to you.
Currently i would not merge it, because it looks more strange than before 😇

@zbycz zbycz force-pushed the master branch 3 times, most recently from 94a02da to d1089f3 Compare December 14, 2025 12:13
@zbycz zbycz force-pushed the master branch 3 times, most recently from 87b5169 to 2675c4f Compare December 19, 2025 22:01
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 13, 2026

Deployment failed with the following error:

Serverless Functions are limited to 2048 mb of memory for personal accounts (Hobby plan). To increase, create a team (Pro plan).

Learn More: https://vercel.link/3c4

@homtec
Copy link
Copy Markdown
Contributor Author

homtec commented Apr 13, 2026

@zbycz did some tweaking. looking forward to your review

@zbycz
Copy link
Copy Markdown
Owner

zbycz commented Apr 17, 2026

Hi,

thanks! Now it looks great. Merging... It will be live in few minutes.

Examples:
image
image
image

Dark mode
image
image

@zbycz zbycz merged commit c1f07ab into zbycz:master Apr 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants