Conversation
|
9c596dc is tested by using I can verify that the
|
There was a problem hiding this comment.
Thanks for digging into this @evnchn. Just two things I noticed:
- non-sub-page hashes are not tracked anymore (for example there are no events fired to plausible if you go to documentation/markdown and then use the side bar to navigate to different demos)
- description of the PR still says "Added a handler... " which is not in the code
|
@rodja as mentioned privately, I do not think we should track the hash when our page isn't doing hash based routing. As a reminder, hash-based routing is intended for websites which use Since we use the hash for sections inside a page, insist on tracking the hash with Plausible assuming hash-based routing has several disadvantages:
A real solution would be to use custom events to track if the particular hash's content appeared on screen. Nevertheless, if you prefer following old behaviour, you may change to plausible.init({
hashBasedRouting: true
})
|
rodja
left a comment
There was a problem hiding this comment.
You are right about the hash tracking. Maybe we will do your suggested "real solution" with custom events to track if the particular hash's content appeared on screen at some point. But this PR is good to go from my side.
|
When this is merged, I intend to export all data off Plausible, then reset site data, modify it to unify all hash based paths, and re-load the modified data. We are rewriting the history as if hash-based navigation logging was never enabled on day 1. |

Motivation
NiceGUI's SPA is totally not known to Plausible, as such the analytics is quite messed up.
Implementation
This pull request updates the Plausible analytics script to a newer version that automatically handles Single-Page Application (SPA) tracking.
Progress