Preserve @bindable_dataclass return type (fixes #5798)#5807
Open
platinops wants to merge 4 commits intozauberzeug:mainfrom
Open
Preserve @bindable_dataclass return type (fixes #5798)#5807platinops wants to merge 4 commits intozauberzeug:mainfrom
@bindable_dataclass return type (fixes #5798)#5807platinops wants to merge 4 commits intozauberzeug:mainfrom
Conversation
4 tasks
platinops
changed the title
@bindable_dataclass return type (fixes #5798)
Collaborator
|
Hello @platinops. Could you please ensure mypy and pylint passes? Thanks. |
evnchn
added
feature
4 tasks
Contributor
Author
|
Hi @evnchn, looks like the mypy errors are gone with the latest commit. |
evnchn
added
review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in #5798, typing breaks on a class decorated with
bindable_dataclass.Implementation
This PR implements the solution brought forward by @falkoschindler: #5798 (comment)
I verified it's working on both my Windows and Red Hat Linux VS Code environments.
Progress