ui.skip_to_main: skip to main content button#5790
ui.skip_to_main: skip to main content button#5790evnchn wants to merge 1 commit intozauberzeug:mainfrom
ui.skip_to_main: skip to main content button#5790Conversation
|
Thanks for the contribution, @evnchn! The "skip to main content" feature is certainly a great accessibility improvement. One note for future PRs: It's best to lead with what the change does and how it works, so reviewers can quickly understand the PR. Personal context and background story are fine to include as a comment on the PR, but keeping the description itself focused on the technical substance helps people "pick up" the PR faster - and keeps commit messages clean when squash-merging. |
|
Been a while since I wrote any PR message. Will bear this in mind 🙇 @falkoschindler as you scheduled this for 3.10, do you think it's a good idea to schedule #5795 also for 3.10 as well? And preferably early 3.10 so that I can get the accessibility documentation by late 3.10. |
Motivation
These days, I have been testing some stuff on my Windows laptop (for multi-Claude as well - you can do so much with a MacBook).
My Windows laptop's touchpad has broke for several years now (thanks Lenovo), and TIL
https://nicegui.iodoes NOT offer a "skip to main content" function for us tab-navigators.Implementation
The PR was bootstrapped by Claude Code but it was utter garbage tbh.
ui.skip_to_main()nicegui/static/nicegui.cssI question everything and whittled things down.
Progress
Pending tasks to be handled when this PR received current-version assignment in milestones. Anyone can take a shot at the tasks if they want. PRs are welcome.
Test script
Final notes
This PR description is manually-written, if it isn't obvious enough already...