Merged
Conversation
zarusz
force-pushed
the
feature/v3_circuit_breaker
branch
from
d63b275 to
841bdc9
Compare
zarusz
force-pushed
the
feature/v3_circuit_breaker
branch
2 times, most recently
from
dfdda2f to
c58fab3
Compare
Owner
Author
|
@EtherZa fyi I've added a refactor commit to shift the circuit breaking logging away from the Host to the plugin. Will ping you once the PR is ready for review. |
zarusz
force-pushed
the
feature/v3_circuit_breaker
branch
3 times, most recently
from
ea21d9c to
fdb7cd0
Compare
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
zarusz
force-pushed
the
feature/v3_circuit_breaker
branch
from
fdb7cd0 to
69a3823
Compare
Owner
Author
|
@EtherZa when you have a moment please review. |
Contributor
|
@zarusz I'm making my way through the PR but the night is stretching on for me. I will probably only finish getting through it tomorrow. |
EtherZa
reviewed
Jan 6, 2025
src/SlimMessageBus.Host.CircuitBreaker.HealthCheck/IConsumerCircuitBreaker.cs
Outdated
Show resolved
Hide resolved
...eBus.Host.CircuitBreaker.HealthCheck/HealthCheckCircuitBreakerAbstractConsumerInterceptor.cs
Outdated
Show resolved
Hide resolved
zarusz
force-pushed
the
feature/v3_circuit_breaker
branch
2 times, most recently
from
dcaff9e to
1f5fc36
Compare
Owner
Author
|
@EtherZa thanks for the feedback. Please have a look once more and if looking good then I will merge. |
Signed-off-by: Tomasz Maruszak <maruszaktomasz@gmail.com>
zarusz
force-pushed
the
feature/v3_circuit_breaker
branch
from
1f5fc36 to
a1fce9d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #251 and #282 with refinements to shift breaker logic to the plugin and away from the Host layer.