Skip to content

replacer: add support for specifying the method#7047

Open
ArkaprabhaChakraborty wants to merge 1 commit intozaproxy:mainfrom
ArkaprabhaChakraborty:replacer-method
Open

replacer: add support for specifying the method#7047
ArkaprabhaChakraborty wants to merge 1 commit intozaproxy:mainfrom
ArkaprabhaChakraborty:replacer-method

Conversation

@ArkaprabhaChakraborty
Copy link
Contributor

@ArkaprabhaChakraborty ArkaprabhaChakraborty commented Jan 9, 2026

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ArkaprabhaChakraborty
Copy link
Contributor Author

ArkaprabhaChakraborty commented Jan 9, 2026

I have read the CLA Document and I hereby sign the CLA

@psiinon
Copy link
Member

psiinon commented Jan 9, 2026 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 516d6567-2433-4464-9730-afc73b1cd3e5

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Privacy_Violation /addOns/llm/src/main/java/org/zaproxy/addon/llm/services/LlmCommunicationService.java: 186

Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

@thc202 thc202 changed the title Add support for specifying the method in replacer AddOn replacer: add support for specifying the method Jan 9, 2026
@thc202
Copy link
Member

thc202 commented Jan 9, 2026

The changlog needs to be updated. Would be good to have tests for the new behaviour.

@kingthorin
Copy link
Member

kingthorin commented Jan 9, 2026

The help probably needs attention as well.

@thc202
Copy link
Member

thc202 commented Jan 12, 2026

The GUI error needs to be addressed and the generated tests trimmed/cleaned up.

@ArkaprabhaChakraborty
Copy link
Contributor Author

ArkaprabhaChakraborty commented Jan 13, 2026

GUI error fixed

image

@thc202
Copy link
Member

thc202 commented Jan 13, 2026

Changes need to be pushed.

@ArkaprabhaChakraborty
Copy link
Contributor Author

ArkaprabhaChakraborty commented Jan 13, 2026

Oops forgot spotlessApply

@thc202 thc202 removed their request for review January 13, 2026 17:45
@thc202
Copy link
Member

thc202 commented Jan 13, 2026

There's still pending comments.

@ArkaprabhaChakraborty
Copy link
Contributor Author

ArkaprabhaChakraborty commented Jan 13, 2026

There's still pending comments.

Yes, just noticed I had removed some comments. Added them back

@thc202 thc202 removed their request for review January 17, 2026 09:29
@thc202
Copy link
Member

thc202 commented Jan 17, 2026

#7047 (comment) The second part of this comment is still pending.

thc202
thc202 reviewed Jan 18, 2026
View reviewed changes
@ArkaprabhaChakraborty
Add support for specifying the method in replacer AddOn
836c90d 
Signed-off-by: ArkaprabhaChakraborty <chakrabortyarkaprabha998@gmail.com>
ritorhymes pushed a commit to ritorhymes/cla that referenced this pull request Jan 22, 2026
@zapbot
@ArkaprabhaChakraborty has signed the CLA in zaproxy/zap-extensions#7047
93ca874
@thc202 thc202 removed their request for review February 3, 2026 11:10
@thc202
Copy link
Member

thc202 commented Feb 3, 2026

See #7047 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thc202 thc202 thc202 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replacer: Add support for specifying the method

4 participants

@ArkaprabhaChakraborty @psiinon @thc202 @kingthorin