Skip to content

Params Initial Relocation#6933

Open
kingthorin wants to merge 1 commit intozaproxy:mainfrom
kingthorin:migrate-params
Open

Params Initial Relocation#6933
kingthorin wants to merge 1 commit intozaproxy:mainfrom
kingthorin:migrate-params

Conversation

@kingthorin
Copy link
Member

@kingthorin kingthorin commented Nov 21, 2025

Initial relocation of the Params extension/add-on from core.

@kingthorin
Copy link
Member Author

kingthorin commented Nov 21, 2025 •
edited
Loading

Add-on loads and works as expected. Help doesn't work for some reason that I haven't been able to nail down. (I've compared vs spider and don't see the missing bit).

I still need to address the DB bits.

Turns out there were not images/icons in use.

@kingthorin kingthorin force-pushed the migrate-params branch 2 times, most recently from 77cd1e0 to 76933e1 Compare November 21, 2025 14:15
@psiinon
Copy link
Member

psiinon commented Nov 21, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 2e55c256-3366-4de6-9021-03b0f53c73fe

Great job! No new security vulnerabilities introduced in this pull request

Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

@kingthorin kingthorin force-pushed the migrate-params branch 2 times, most recently from 08eff9c to 08bfcb1 Compare November 21, 2025 14:21
@thc202
Copy link
Member

thc202 commented Nov 21, 2025

This will have to be synced once zaproxy/zaproxy#9148 is merged.

@kingthorin kingthorin force-pushed the migrate-params branch 2 times, most recently from 966a468 to 46f8476 Compare November 21, 2025 14:36
kingthorin
kingthorin commented Nov 21, 2025
View reviewed changes
addOns/params/gradle.properties
@@ -0,0 +1,2 @@
version=0.0.1
Copy link
Member Author

@kingthorin kingthorin Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.0?

kingthorin
kingthorin commented Nov 21, 2025
View reviewed changes
addOns/params/params.gradle.kts

zapAddOn {
addOnName.set("Params")
addOnStatus.set(AddOnStatus.RELEASE)
Copy link
Member Author

@kingthorin kingthorin Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different status?

@kingthorin
Copy link
Member Author

kingthorin commented Nov 21, 2025

This will have to be synced once zaproxy/zaproxy#9148 is merged.

That would mean depending on a core snapshot wouldn't it?

@thc202
Copy link
Member

thc202 commented Nov 21, 2025

No, can use reflection.

@kingthorin
Copy link
Member Author

kingthorin commented Nov 21, 2025

Oh like it'll just use the functionality if available, then later when targeting 2.17 or whatever it can use the code directly?

@kingthorin
Params Initial Relocation
2f7e7ee 
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

kingthorin commented Dec 17, 2025

This will have to be synced once zaproxy/zaproxy#9148 is merged.

I've ported these changes.

@kingthorin
Copy link
Member Author

kingthorin commented Jan 6, 2026

Let's proceed with this one for now. I'll tackle moving DB bits in another PR.

@kingthorin kingthorin mentioned this pull request Jan 6, 2026
Open
5 tasks
@kingthorin kingthorin marked this pull request as ready for review January 30, 2026 14:27
@kingthorin
Copy link
Member Author

kingthorin commented Jan 30, 2026 •
edited
Loading

Not draft, DB will be done in another step.

See zaproxy/zaproxy#9210

@kingthorin kingthorin mentioned this pull request Jan 30, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kingthorin @psiinon @thc202