chore: fresh entropy on RNGs - #791
Open
titouantanguy wants to merge 8 commits into
Open
Conversation
titouantanguy
commented
Aug 25, 2026
titouantanguy
commented
Aug 25, 2026
kc1212
requested changes
Aug 25, 2026
kc1212
left a comment
Contributor
There was a problem hiding this comment.
Great work! I left some comments
Contributor
Author
|
Somewhat big refactor after the initial review to make the RngRegistry a global static so that it doesn't depend on a partiuclar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a global registry that holds weak references to the rngs derived from the BaseKmsStruct.
Upon new epoch, refresh all those RNGs by making a seed from current RNG and adding entropy from OS and ,if available, the security module.
Related issue(s)
https://github.com/zama-ai/kms-internal/issues/3150
PR Checklist
Tick all that apply — by ticking I attest the item holds; justify any deviation in the description above.
chore: ...).pubitem and test coverage has not decreased.TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + review requested.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
More details in CONTRIBUTING.md and AGENTS.md.