Conversation
Consolidated Tests Results 2026-05-06 - 11:09:22Test ResultsDetails
test-reporter: Run #1926
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
There was a problem hiding this comment.
Pull request overview
Adds explicit slow-tests coverage for the “compressed keygen from existing shares” migration path when OPRF private-key shares may already exist or be missing (legacy material), and updates test helpers to control copy_compressed_key_to_original behavior.
Changes:
- Split the existing “compressed keygen from existing” test into two slow-tests to cover both “OPRF present” and “OPRF missing” scenarios.
- Add utilities to rewrite stored key material to simulate legacy fixtures missing dedicated OPRF shares and restart servers from disk material.
- Extend
keygen_config_from_existingtest helper to pass throughcopy_compressed_key_to_original.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/service/src/client/tests/threshold/key_gen_tests.rs | Adds two migration-focused tests plus helper routines to simulate legacy missing-OPRF material and restart servers from persisted storage. |
| core/service/src/client/tests/common.rs | Extends the test helper to configure copy_compressed_key_to_original in KeySetAddedInfo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jot2re
left a comment
There was a problem hiding this comment.
LGTM besides Daniel's comment
c99ad62 to
285c740
Compare
285c740 to
ca11423
Compare
Description of changes
It turned out that by adding prf keygen, we're already doing the migration implicitly. This PR adds a proper test of migration keygen.
Issue ticket number and link
Closes zama-ai/kms-internal#3010
PR Checklist
I attest that all checked items are satisfied. Any deviation is clearly justified above.
chore: ...).TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + infra-team reviewer assigned.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
Answer in the
Cargo.tomlnext to the dependency (or here if updating):More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md