Deprecate uid_mappings/gid_mappings on top-level Spec#328
Open
nayuta723 wants to merge 1 commit intoyouki-dev:mainfrom
Open
Deprecate uid_mappings/gid_mappings on top-level Spec#328nayuta723 wants to merge 1 commit intoyouki-dev:mainfrom
nayuta723 wants to merge 1 commit intoyouki-dev:mainfrom
Conversation
These fields have never existed in the OCI runtime spec's top-level Spec struct. Mark them as deprecated since 0.10.0 so users are guided to the correct locations: - Linux::uid_mappings / Linux::gid_mappings (user namespace mappings) - Mount::uid_mappings / Mount::gid_mappings (per-mount ID-mapped mounts) Add #[allow(deprecated)] to Default impl to suppress internal compiler warnings. Closes youki-dev#325 Signed-off-by: nayuta723 <nayuta723@gmail.com>
nayuta723
force-pushed
the
remove-top-level-uid-gid-mapping
branch
from
2599b1c to
20eeff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
Mark
uid_mappingsandgid_mappingson the top-levelSpecstruct as deprecated since v0.10.0. These fields have never
existed in the OCI runtime spec's top-level Spec struct. Users
are guided to the correct locations:
Linux::uid_mappings/Linux::gid_mappingsfor user namespace mappingsMount::uid_mappings/Mount::gid_mappingsfor per-mount ID-mapped mountsWhich issue(s) this PR fixes:
Fixes #325
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?