Skip to content

Reorder seteuid() and setegid()#44

Open
DarthGandalf wants to merge 1 commit into
yo8192:masterfrom
DarthGandalf:order
Open

Reorder seteuid() and setegid()#44
DarthGandalf wants to merge 1 commit into
yo8192:masterfrom
DarthGandalf:order

Conversation

@DarthGandalf

Copy link
Copy Markdown
Contributor

Fix #43

I don't know why it broke for Tim. Probably somehow after changing euid (from user which has permission to some other user?) changing egid isn't allowed anymore. For me fcrontab works both without and with this patch.

Fix yo8192#43

I don't know why it broke for Tim. Probably somehow after changing euid
(from user which has permission to some other user?) changing egid isn't
allowed anymore. For me fcrontab works both without and with this patch.
@yo8192

yo8192 commented Mar 15, 2026

Copy link
Copy Markdown
Owner

Thanks. It looks OK at first sight, but I'm slightly concerned it may break something on some non-Linux platform.
I'd feel more comfortable with this if we found some backing to justify that we had the wrong order, we were just lucky it still worked for a large majority of people/platforms, but the right order is indeed the one in this PR (rather than the other way round!).

@DarthGandalf

Copy link
Copy Markdown
Contributor Author

I'd feel more comfortable with this if we found some backing

Me too :) But I cannot reproduce that issue myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

seteuid() & setegid() order in fcrontab remove_as_user()

2 participants